Skip to content

Reading Authority Aliases #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 2, 2019
Merged

Reading Authority Aliases #25

merged 9 commits into from
Apr 2, 2019

Conversation

@abhidnya13
Copy link
Contributor

@abhidnya13 abhidnya13 commented Mar 25, 2019 •
edited by rayluo
Loading

This PR covers the first two parts of Authority Migration mentioned as here.

UPDATE: If you prefer, you can install this branch for your smoke testing:

pip install git+https://github.com/AzureAD/microsoft-authentication-library-for-python.git@authority_migration

@abhidnya13 abhidnya13 mentioned this pull request Mar 27, 2019
Closed
rayluo
rayluo requested changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR style looks generally clean! We do need to change a data structure though. Also, can you come up with some auto- unittest cases?

@rayluo rayluo added this to the Testing how milestone works milestone Apr 1, 2019
rayluo
rayluo reviewed Apr 2, 2019
View reviewed changes
Copy link
Contributor

@rayluo rayluo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for new improvements. I like this effort! I'm adding a new commit for some minor refactoring that are too tedious to mention here. We can follow up offline.

@rayluo rayluo force-pushed the authority_migration branch from 9c5a495 to f7e68ef Compare April 2, 2019 01:32
@rayluo rayluo force-pushed the authority_migration branch from f7e68ef to 04b107e Compare April 2, 2019 05:17
@rayluo rayluo changed the title Authority migration Reading Authority Aliases Apr 2, 2019
@abhidnya13 abhidnya13 merged commit f2c2fa1 into dev Apr 2, 2019
@abhidnya13 abhidnya13 mentioned this pull request Apr 2, 2019
Merged
@abhidnya13 abhidnya13 deleted the authority_migration branch April 2, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rayluo rayluo rayluo approved these changes

@henrik-me henrik-me Awaiting requested review from henrik-me

@navyasric navyasric Awaiting requested review from navyasric

@MarkZuber MarkZuber Awaiting requested review from MarkZuber

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Share tokens with MSAL .Net

Development

Successfully merging this pull request may close these issues.

3 participants

@abhidnya13 @rayluo