Release 0.4.1 #63
Merged
Release 0.4.1 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSAL Python 0.4.0
Updating authority URL regexp to not escape question mark
Do not write null into family_id
Avoid hardcoding secret
Handle string time values when caching responses
Previous implementation was largely based on some hallway communication, which happened to not work in sovereign scenario. Neither did we test sovereign scenario for MSAL Python, until now.
Support sovereign cloud.
Bumping version number
henrik-me
approved these changes
Jun 17, 2019
Although not strictly enforced (by pylint) in this repo, we don't want to noticeably exceed that limit. https://www.python.org/dev/peps/pep-0008/#maximum-line-length
Pass through verify flag and fix scopes default value
The previous default None value would cause an exception in our code decorate_scope(). The fix is to change the previously optional scopes parameter to required. This kind of api surface change would usually be a breaking change, but in this case it is not, because the previous default value would cause exception so it was in fact required. FWIW, you can still explicitly use empty list [] as scope, and the response would contain id_token and refresh_token, but no access_token.
…assword-flow Change an optional scopes parameter to be required
Bringing 2 more PRs into pending release-0.4.1 branch
DharshanBJ
pushed a commit
that referenced
this pull request
Oct 4, 2024
The red cross i.e. a CI test failure when merging previous PR 61 into dev branch, was a rare intermittent failure in the CI side. In fact, its previous CI test and its subsequent merging into dev branch have all been successful. Therefore we ignore that red cross, and still proceed with our release. Recording such reasoning here for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the sub-PRs included in this release has been tested and reviewed and approved in their individual PR. The purpose of this all-in-one release PR is to organize the release process. Please review/proof-read the following release notes.
Release Notes:
If you prefer to, you can install this branch for your smoke testing: