Geometry_Engine: Remove Degrees() method for NurbsSurface

[pawelbaran]

!!! PLEASE DO NOT MERGE !!!

NOTE: Depends on

#603

Issues addressed by this PR

Closes #1297

Test files

Test file is located on SharePoint. To run it, please switch to the branches related to the following PRs:

• #603
• #1298
• #120
• #431

The error in the test file is caused by the bug in Cone convert logged here.

Changelog

• BH.Engine.Geometry.Query.Degrees(this NurbsSurface surf) has been removed.

Additional comments

Please see #603.
The PR should not conflict with #1283 as there is no overlap.

[FraserGreenroyd]

Hi @pawelbaran - fully recognise this is a WIP bit of work in conjunction with BHoM/BHoM#603 however, the branch names should be the same in order to allow the CI checks to pass - currently the engine is failing because it cannot find the suitable PR on the core oM.

I recommend branching off your current branch to the correct branch name (matching the oM one) and then remaking the PR - but that can of course be done at the time you're ready for the work to be merged - this is just an advanced heads up 😄

[epignatelli]

Maybe it is a trivial question, but better ask for forgiveness 😄 have you made sure that Degrees is not used anywhere else? Other toolkit especially? As I commented in BHoM/BHoM#603 I think it would be safer to create a new TrimmedSurface object, rather than modifying the NurbsSurface one.

This would avoid us scrabbling through the code to check if we are breaking something, and we do not break past scripts. The rationale is that before this modification, this functionality was not there anyway, so no script could have relied on it.

[pawelbaran]

@epignatelli being honest I must say that atm I have not checked all dependencies as the PRs are still WIP. Nevertheless, as explained in #1297, I believe that we need to remove Degrees for the simple reason that it will never work correctly for certain cases.

Concerning TrimmedSurface vs extending NurbsSurface, as in #603, I prefer the latter, but would rather wait for others to speak up. Whatever we decide, I am happy to do the effort and make sure that the change will not break anything - no worries about that.

[pawelbaran]

Closing this one and reopening in #1319