diff --git a/Etabs_Adapter/Etabs_Adapter.csproj b/Etabs_Adapter/Etabs_Adapter.csproj index 49588993..5ca49c1e 100644 --- a/Etabs_Adapter/Etabs_Adapter.csproj +++ b/Etabs_Adapter/Etabs_Adapter.csproj @@ -41,7 +41,7 @@ Library Properties BH.Adapter.ETABS - ETABS_Adapter + ETABS17_Adapter v4.5.2 512 diff --git a/Etabs_Adapter/Read/Bar.cs b/Etabs_Adapter/Read/Bar.cs index 7b537c47..7bf0834c 100644 --- a/Etabs_Adapter/Read/Bar.cs +++ b/Etabs_Adapter/Read/Bar.cs @@ -49,11 +49,11 @@ public partial class ETABS2016Adapter : BHoMAdapter { /***************************************************/ - private List ReadBars(List ids = null) + private List ReadBar(List ids = null) { List barList = new List(); - Dictionary bhomNodes = ReadNodes().ToDictionary(x => x.CustomData[AdapterId].ToString()); - Dictionary bhomSections = ReadSectionProperties().ToDictionary(x => x.CustomData[AdapterId].ToString()); + Dictionary bhomNodes = ReadNode().ToDictionary(x => x.CustomData[AdapterId].ToString()); + Dictionary bhomSections = ReadSectionProperty().ToDictionary(x => x.CustomData[AdapterId].ToString()); int nameCount = 0; string[] names = { }; @@ -121,7 +121,7 @@ private List ReadBars(List ids = null) /***************************************************/ - private List ReadSectionProperties(List ids = null) + private List ReadSectionProperty(List ids = null) { List propList = new List(); Dictionary bhomMaterials = ReadMaterial().ToDictionary(x => x.Name); @@ -290,8 +290,10 @@ private List ReadSectionProperties(List ids = null) break; } if (dimensions == null) + { Engine.Reflection.Compute.RecordNote(propertyType.ToString() + " properties are not implemented in ETABS adapter. An empty section has been returned."); - constructSelector = "explicit"; + constructSelector = "explicit"; + } #endregion diff --git a/Etabs_Adapter/Read/Link.cs b/Etabs_Adapter/Read/Link.cs index b6f2f97e..edacddaa 100644 --- a/Etabs_Adapter/Read/Link.cs +++ b/Etabs_Adapter/Read/Link.cs @@ -94,7 +94,7 @@ private List ReadRigidLink(List ids = null) string endId = ""; m_model.LinkObj.GetPoints(kvp.Key, ref startId, ref endId); - List endNodes = ReadNodes(new List { startId, endId }); + List endNodes = ReadNode(new List { startId, endId }); bhLink.MasterNode = endNodes[0]; bhLink.SlaveNodes = new List() { endNodes[1] }; } @@ -117,7 +117,7 @@ private List ReadRigidLink(List ids = null) nodeIdsToRead.Add(endId); } - List endNodes = ReadNodes(nodeIdsToRead); + List endNodes = ReadNode(nodeIdsToRead); bhLink.MasterNode = endNodes[0]; endNodes.RemoveAt(0); bhLink.SlaveNodes = endNodes; diff --git a/Etabs_Adapter/Read/Load.cs b/Etabs_Adapter/Read/Load.cs index e5515428..fee686e9 100644 --- a/Etabs_Adapter/Read/Load.cs +++ b/Etabs_Adapter/Read/Load.cs @@ -157,7 +157,7 @@ private List ReadPointLoad(List loadcases) { List bhLoads = new List(); - Dictionary bhomNodes = ReadNodes().ToDictionary(x => x.CustomData[AdapterId].ToString()); + Dictionary bhomNodes = ReadNode().ToDictionary(x => x.CustomData[AdapterId].ToString()); string[] names = null; string[] loadcase = null; @@ -201,7 +201,7 @@ private List ReadBarLoad(List loadcases) { List bhLoads = new List(); - Dictionary bhomBars = ReadBars().ToDictionary(x => x.CustomData[AdapterId].ToString()); + Dictionary bhomBars = ReadBar().ToDictionary(x => x.CustomData[AdapterId].ToString()); string[] names = null; string[] loadcase = null; diff --git a/Etabs_Adapter/Read/Node.cs b/Etabs_Adapter/Read/Node.cs index a2b53300..bfc709f5 100644 --- a/Etabs_Adapter/Read/Node.cs +++ b/Etabs_Adapter/Read/Node.cs @@ -42,7 +42,7 @@ using BH.oM.Geometry; using BH.Engine.Geometry; using BH.Engine.Reflection; -using BH.oM.Architecture.Elements; +using BH.oM.Geometry.SettingOut; using BH.oM.Adapters.ETABS.Elements; namespace BH.Adapter.ETABS @@ -55,7 +55,7 @@ public partial class ETABS2016Adapter : BHoMAdapter { /***************************************************/ - private List ReadNodes(List ids = null) + private List ReadNode(List ids = null) { List nodeList = new List(); diff --git a/Etabs_Adapter/Read/_Read.cs b/Etabs_Adapter/Read/_Read.cs index 604ab887..e43a891d 100644 --- a/Etabs_Adapter/Read/_Read.cs +++ b/Etabs_Adapter/Read/_Read.cs @@ -42,6 +42,7 @@ using BH.oM.Geometry; using BH.Engine.Geometry; using BH.Engine.Reflection; +using BH.oM.Geometry.SettingOut; using BH.oM.Architecture.Elements; using BH.oM.Adapters.ETABS.Elements; @@ -60,11 +61,11 @@ public partial class ETABS2016Adapter : BHoMAdapter protected override IEnumerable Read(Type type, IList ids) { if (type == typeof(Node)) - return ReadNodes(ids as dynamic); + return ReadNode(ids as dynamic); else if (type == typeof(Bar)) - return ReadBars(ids as dynamic); + return ReadBar(ids as dynamic); else if (type == typeof(ISectionProperty) || type.GetInterfaces().Contains(typeof(ISectionProperty))) - return ReadSectionProperties(ids as dynamic); + return ReadSectionProperty(ids as dynamic); else if (type == typeof(IMaterialFragment)) return ReadMaterial(ids as dynamic); else if (type == typeof(Panel)) @@ -81,7 +82,7 @@ protected override IEnumerable Read(Type type, IList ids) return ReadRigidLink(ids as dynamic); else if (type == typeof(LinkConstraint)) return ReadLinkConstraints(ids as dynamic); - else if (type == typeof(Level)) + else if (type == typeof(oM.Geometry.SettingOut.Level) || type == typeof(oM.Architecture.Elements.Level)) return ReadLevel(ids as dynamic); else if (type == typeof(FEMesh)) return ReadMesh(ids as dynamic);