Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RhinoCommon 5 and RhinoCommon 6 have different representations of the objects, although the API is the same #137

Closed
epignatelli opened this issue Feb 6, 2020 · 2 comments · Fixed by #148
Assignees
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos

Comments

@epignatelli
Copy link
Member

Description:

Thanks to @kThorsager, who discovered this issue while dealing with NurbsCurves: #135 and #136.

We found that Rhino.Geometry.ControlPoints, whilst keeping the same API, it asks for a different representation between RhinoCommon v5 and RhinoCommon v6. This is explicit in their documentation as shown below:

Rhino 5
ED4D808D

Rhino 6
image

@kThorsager has gone through the v5 documentation and found the following test script:
https://developer.rhino3d.com/5/api/RhinoCommonWin/html/M_Rhino_Geometry_Collections_NurbsCurvePointList_SetPoint_2.htm#ID0EBBBBA_tab1

If we run this script in the two versions of rhino, we get different behaviours:

Rhino 5
4C4DEF23

Rhino 6
47A816C8

We need to test all the other Convert methods to understand how spread is the problem.
For the moment, I would advice against using the BHoM with Rhinoceros 6, until we have solved this issue.

The ultimate goal for this issue is to provide full compatibility for Rhinoceros 6.

Test file(s):

You can use the test file in #135

@al-fisher @alelom FYI

@epignatelli epignatelli added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Feb 6, 2020
@epignatelli epignatelli added this to the BHoM 3.1 β RC milestone Feb 6, 2020
@epignatelli epignatelli self-assigned this Feb 6, 2020
@epignatelli epignatelli pinned this issue Feb 6, 2020
@pawelbaran
Copy link
Member

Just curious: we've spotted that some curves internalized in GH under Rhino5 were flipped when the same script is opened in Rhino6. Is that something that could relate this issue by any means?

@epignatelli
Copy link
Member Author

It is very probable that the issue is related, in my opinion, but I can't be 100% sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants