Reduce status from error to warning for attributes in order check #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
approved these changes
Jan 20, 2025
Member
adecler
left a comment
adecler
left a comment
There was a problem hiding this comment.
Very happy to approve this !
100% agreed with this issue and the way it was solved
Contributor
Author
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
IsakNaslundBh
deleted the
Test_Toolkit-#497-InputAttributesInOrderReducedToWarning
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #497
Fixes issue where inputs in order where treated as an error, unnecessarily blocking PRs from merge. Check still useful, but should be a warning.
Test files
Changelog
Additional comments