Notifications are not taking users to an activity - instead, they are seeing a blank screen

[elenamrv]

We have reports from different that users that when they click on a notification, they are not taken to the intended activity or survey. Instead, they see a blank screen OR are shown an "error." Please see the below for a video of the issue:

Video.mov.zip

I think this was a previous issue, but the problem seems to persist.

[sarithapillai8]

@elenamrv
The notification gets expired after the time limit - 5mins. In the video it is shown as the notification received 13mins ago. This is not actually rendering the blank page, instead it is showing expired popup, and redirected to home screen as it is expired.

[elenamrv]

@sarithapillai8 is it possible to make it so that a notification will always take you to the desired activity? 5 minutes is a very short window.

[sarithapillai8]

@avaidyam @elenamrv
The notification is for the scheduled activity. If we do not need any time restriction for this schedule, we can remove the expiry. Otherwise we need to manage different expiry time based on the schedule type.
For eg : Hourly scheduled activity will have 1 hour expiry limit, daily will have 24 hour , once in 3 hours will have 3 hour expiry time.
So could you please confirm notification expiry is not needed at all or do we need to manage it based on schedule type?

[avaidyam]

@sarithapillai8 @elenamrv So this sounds more like a quick fix for @Linoy339 to update the expiry parameter, and the blank screen is actually bugs #37 and #52.

[Linoy339]

@avaidyam . Is it to make expiry as null or to update it in a manner which @sarithapillai8 said ?

[avaidyam]

@Linoy339 Let's make it 6 hours for now (i.e. 6h * 60m * 60s * 1000ms = 21600000ms). In the future the expiry parameter may need to come from the Activity's schedule (allowing clinicians to set it), but @sarithapillai8's suggestion is a good idea for when we implement this.

[Linoy339]

Yes. We will make it 6 hours then for time being

[Linoy339]

@avaidyam . Its done. Please check BIDMCDigitalPsychiatry/LAMP-server#35

[avaidyam]

@Linoy339 Great - just merged it. All of these changes are now in the staging environment so could you do another round of stability testing to make sure nothing crashes/fails before we push to production?

[Linoy339]

@avaidyam . We will do a round of testing and let you know

[Linoy339]

@avaidyam. We have tested. Its found that no apns-collapse-id in app-gateway ios notification part. This is required for autoremoval of notification after expiry period(as @jijopulikkottil said). Also, deviceType need to be passed inorder to identify whether its phone or watch. For phone, the apns-push-type should be "alert" and "background" for the watch. All these changes has been pushed and initiated a pull request in app- gateway. Please check BIDMCDigitalPsychiatry/LAMP-app-gateway#4

Also, we had to do some minor change(notificationId generation and removal of headers) in notification sending part in LAMP-server. This is also given as a pull request.
Please check BIDMCDigitalPsychiatry/LAMP-server#36

[avaidyam]

@Linoy339 I think these changes should only be made in LAMP-server and not in LAMP-app-gateway. These same parameters can be added to the body of the request already. Please make a new PR to update the LAMP-server repo with these minor changes.

[Linoy339]

@avaidyam . But, apns-collapse-id and apns-push-type need to be passed from app-gateway like this :
https://github.com/BIDMCDigitalPsychiatry/LAMP-app-gateway/pull/4/files#diff-e07d531ac040ce3f40e0ce632ac2a059d7cd60f20e61f78268ac3be015b3b28fR75

Can you please check ?

[avaidyam]

@Linoy339 This is the correct implementation for adding support for those parameters. Please adjust your code accordingly.

[Linoy339]

Okay. Is the new changes in app-gateway changes deployed in server. Can I call test it locally ?

[avaidyam]

@Linoy339 Yes - the changes should be live.

[Linoy339]

@avaidyam .Can you please put buffer variable above the HEADERS variable. Its making some error, it seems. Buffer got initialized after preparing HEADERS in which buffer variable is used.

https://github.com/BIDMCDigitalPsychiatry/LAMP-app-gateway/blob/master/app.js#L73

[avaidyam]

Done and updated!

[Linoy339]

Thank you.

[Linoy339]

Please check
BIDMCDigitalPsychiatry/LAMP-server#37