Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Datasets): track sample and columns view opened events #942

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cheikhgwane
Copy link
Contributor

Instrument Dataset Explorer to measure feature adoption. (See reference document)

Changes

Please list / describe the changes in the codebase for the reviewer(s).

  • Track datasets.dataset_file_previewed for dataset sample preview tab.
  • Track datasets.dataset_file_metadata_accessed for dataset columns metadata tab.

How/what to test

  • Enable the analytics your local front-end app : set DISABLE_ANALYTICS=false
  • On the back-end also set MIXPANEL_TOKEN env variable (you can find the token on mixpanel).

Screenshots / screencast

Screenshot 2024-12-11 at 11 53 33

Copy link
Contributor

@YolanFery YolanFery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good !

Only issue I have found is that on my side events are duplicated and sent in pairs (the component is rendering/mounting twice [and sending tracking events twice ] ?) But this also the case for existing events (like dataset_open)

Screenshot 2024-12-11 at 14 45 15

Maybe we want some throttling on those trackEvent calls

@cheikhgwane
Copy link
Contributor Author

cheikhgwane commented Dec 11, 2024

Tested, looks good !

Only issue I have found is that on my side events are duplicated and sent in pairs (the component is rendering/mounting twice [and sending tracking events twice ] ?) But this also the case for existing events (like dataset_open)

Screenshot 2024-12-11 at 14 45 15 Maybe we want some throttling on those `trackEvent` calls

Thx, ^-^! Yes, It's due to react.StrictMode (enabled by default on dev environment) that re-render the component twice. Good idea for the throttling, to explore !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants