Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point light API #535

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Conversation

marceline-cramer
Copy link
Contributor

@marceline-cramer marceline-cramer commented Dec 7, 2023

  • Define PointLight and supporting handles
  • Add point light Renderer API
  • Shade point lights in opaque pass
  • Add point lights to cube example

Checklist

  • CI Checked:
    • cargo fmt has been ran
    • cargo clippy reports no issues
    • cargo test succeeds
    • cargo rend3-doc has no warnings
    • cargo deny check issues have been fixed or added to deny.toml
  • Manually Checked:
    • relevant examples/test cases run
    • changes added to changelog
      • Add credit to yourself for each change: Added new functionality @githubname.

Related Issues

Description

Adds a rudimentary point light API. No clusters and no shadow mapping yet.

20231207_02h59m01s_grim

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely fabulous code!

I have some small changes, but by and large the code fits in extremely well and looks great

examples/cube/src/lib.rs Outdated Show resolved Hide resolved
rend3-routine/shaders/src/depth.wgsl Outdated Show resolved Hide resolved
rend3-routine/shaders/src/opaque.wgsl Outdated Show resolved Hide resolved
rend3-routine/shaders/src/opaque.wgsl Outdated Show resolved Hide resolved
rend3-routine/shaders/src/opaque.wgsl Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooooo!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 12, 2023 03:51
@cwfitzgerald cwfitzgerald merged commit d7806f5 into BVE-Reborn:trunk Dec 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants