-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UWP support to BabylonReactNative #137
Changes from all commits
3256064
6e55b8c
1e96682
0c3b117
7cb9a19
f8cb2b1
e5c243c
5500b7d
740cdd1
6e0642b
f46a5d4
ba04d8d
321625f
6d7eec3
344aa12
0c3cbd6
2d9ef2d
5e18391
4c5778f
f0bed54
d98762d
fd3335e
c28b098
07b127f
9ac1c23
0fe138a
b8c0384
7962233
0d7e725
4adc50c
caa66e4
8498e69
a6c8486
4abc4f8
ba05041
09b0090
9b012f2
6055788
6339293
ce79ce9
d3d9413
910f79f
e2b0e98
1b7f62a
fd740a8
4442fac
2aeeb7f
37f80fe
8e92ef3
e2e5086
d89f4e0
0300c5d
1ae6ee7
efa7fb4
130874b
cd326b3
af82b5a
a775a06
72606db
af5f0b6
90daed8
d6050ba
1a33cf9
ecc21cb
98e1d5d
5585d9f
6d9b1bb
0dc287a
3f2a26b
466f94d
874dbc3
3ec80d2
910c952
465d9c3
336535f
874fa7f
78b388a
4515879
d211e8f
5a5e093
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,3 +61,8 @@ buck-out/ | |
|
||
# CocoaPods | ||
/ios/Pods/ | ||
|
||
# UWP | ||
build.binlog | ||
deploy.binlog | ||
msbuild.binlog |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ | |
"scripts": { | ||
"android": "react-native run-android", | ||
"ios": "react-native run-ios", | ||
"windows": "react-native run-windows --arch x64", | ||
"windows-verbose": "react-native run-windows --arch x64 --logging", | ||
"start": "react-native start", | ||
"test": "jest", | ||
"lint": "eslint . --ext .js,.jsx,.ts,.tsx" | ||
|
@@ -13,28 +15,30 @@ | |
"@babylonjs/core": "^5.0.0-alpha.6", | ||
"@babylonjs/loaders": "^5.0.0-alpha.6", | ||
"@babylonjs/react-native": "file:../../Modules/@babylonjs/react-native", | ||
"@react-native-community/slider": "^2.0.9", | ||
"@react-native-community/slider": "4.0.0-rc.2", | ||
"logkitty": "^0.7.1", | ||
"react": "16.13.1", | ||
"react-native": "0.63.1", | ||
"react-native-permissions": "^2.1.4" | ||
"react": "^17.0.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ryantrem are there any limitations to what react/react-native version we can use? What is required for testing when moving to a newer version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have consumers on lower versions of React so we need to be a bit careful not to break them, but I think React 17 had more implementation fixes than API changes, so it's probably ok. |
||
"react-native": "^0.64.0-rc.0", | ||
"react-native-permissions": "^3.0.0", | ||
"react-native-windows": "0.64.0-preview.5" | ||
}, | ||
"devDependencies": { | ||
"@babel/core": "^7.8.4", | ||
"@babel/runtime": "^7.8.4", | ||
"@react-native-community/cli": "^4.13.0", | ||
"@react-native-community/eslint-config": "^1.1.0", | ||
"@types/jest": "^25.2.3", | ||
"@types/react-native": "0.63.1", | ||
"@types/react": "^16.9.0", | ||
"@types/react-native": "^0.63.18", | ||
"@types/react-test-renderer": "^16.9.2", | ||
"@typescript-eslint/eslint-plugin": "^2.27.0", | ||
"@typescript-eslint/parser": "^2.27.0", | ||
"babel-jest": "^25.1.0", | ||
"eslint": "^6.5.1", | ||
"eslint": "7.12.0", | ||
"jest": "^25.1.0", | ||
"metro-react-native-babel-preset": "^0.59.0", | ||
"prettier": "^2.0.4", | ||
"react-test-renderer": "16.13.1", | ||
"react-test-renderer": "^17.0.1", | ||
"typescript": "^3.8.3" | ||
}, | ||
"jest": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
*AppPackages* | ||
*BundleArtifacts* | ||
|
||
#OS junk files | ||
[Tt]humbs.db | ||
*.DS_Store | ||
|
||
#Visual Studio files | ||
*.[Oo]bj | ||
*.user | ||
*.aps | ||
*.pch | ||
*.vspscc | ||
*.vssscc | ||
*_i.c | ||
*_p.c | ||
*.ncb | ||
*.suo | ||
*.tlb | ||
*.tlh | ||
*.bak | ||
*.[Cc]ache | ||
*.ilk | ||
*.log | ||
*.lib | ||
*.sbr | ||
*.sdf | ||
*.opensdf | ||
*.opendb | ||
*.unsuccessfulbuild | ||
ipch/ | ||
[Oo]bj/ | ||
[Bb]in | ||
[Dd]ebug*/ | ||
[Rr]elease*/ | ||
Ankh.NoLoad | ||
|
||
# Visual C++ cache files | ||
ipch/ | ||
*.aps | ||
*.ncb | ||
*.opendb | ||
*.opensdf | ||
*.sdf | ||
*.cachefile | ||
*.VC.db | ||
*.VC.VC.opendb | ||
|
||
#MonoDevelop | ||
*.pidb | ||
*.userprefs | ||
|
||
#Tooling | ||
_ReSharper*/ | ||
*.resharper | ||
[Tt]est[Rr]esult* | ||
*.sass-cache | ||
|
||
#Project files | ||
[Bb]uild/ | ||
|
||
#Subversion files | ||
.svn | ||
|
||
# Office Temp Files | ||
~$* | ||
|
||
# vim Temp Files | ||
*~ | ||
|
||
#NuGet | ||
packages/ | ||
*.nupkg | ||
|
||
#ncrunch | ||
*ncrunch* | ||
*crunch*.local.xml | ||
|
||
# visual studio database projects | ||
*.dbmdl | ||
|
||
#Test files | ||
*.testsettings | ||
|
||
#Other files | ||
*.DotSettings | ||
.vs/ | ||
*project.lock.json | ||
|
||
#Files generated by the VS build | ||
**/Generated Files/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does
blockList
relate toblackListRE
, which we used in another project and intended to bring into this project (to match the solution here: react-native-community/cli#1238). @CoPrez do you have any insights?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason react-native-windows moved from blacklists to blocklists in December. I'll reach out to react-native-windows owners to see why
In reply to: 557654635 [](ancestors = 557654635)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talking to some different folks, it sounds like this was a rename in the metro version included with react-native 0.64. It should do the same things as before and is just a rename
In reply to: 560367678 [](ancestors = 560367678,557654635)