Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix large file missing SSE-C key ID #423

Merged

Conversation

jsuchan-reef
Copy link
Collaborator

@jsuchan-reef jsuchan-reef commented Sep 26, 2023

  • fixes large file missing key ID #422

  • Key ID included in a header with each uploaded part doesnt suffice, it needs to be passed in file_info when calling .start_large_file().

@jsuchan-reef jsuchan-reef force-pushed the yed/fix-large-file-key-id branch from e8d083f to 6c410f3 Compare September 26, 2023 20:21
new_message = unauthorized.message
if new_message == '':
new_message = 'unauthorized'
new_message = unauthorized.message or 'unauthorized'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(unrelated) fix for the following error

  File "/Users/yeef/dev/b2/b2-sdk-python/b2sdk/session.py", line 462, in _wrap_token
    return self._reauthorization_loop(partial_callback)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yeef/dev/b2/b2-sdk-python/b2sdk/session.py", line 486, in _reauthorization_loop
    raise self._add_app_key_info_to_unauthorized(e)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yeef/dev/b2/b2-sdk-python/b2sdk/session.py", line 515, in _add_app_key_info_to_unauthorized
    new_message += ' for application key ' + ', '.join(key_messages)
TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'

@jsuchan-reef jsuchan-reef changed the title fix missing file_info.sse_c_key_id for large file - Sep 26, 2023
@jsuchan-reef jsuchan-reef changed the title - fix large file missing SSE-C key ID Sep 27, 2023
@jsuchan-reef jsuchan-reef reopened this Sep 27, 2023
@mjurbanski-reef mjurbanski-reef merged commit 874089d into Backblaze:master Sep 27, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

large file missing key ID
2 participants