From ef8cac1bc266aa5c2f2aa7cd6fbc595af3a80329 Mon Sep 17 00:00:00 2001
From: mdaneri <max.daneri@broadcom.com>
Date: Mon, 30 Sep 2024 17:23:37 -0700
Subject: [PATCH 1/2] Add new e 'Check for Duplicate Function Definitions test

---
 tests/unit/_.Tests.ps1 | 48 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

diff --git a/tests/unit/_.Tests.ps1 b/tests/unit/_.Tests.ps1
index 61e8aad23..53bc5a14d 100644
--- a/tests/unit/_.Tests.ps1
+++ b/tests/unit/_.Tests.ps1
@@ -1,4 +1,5 @@
 [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '')]
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingWriteHost', '')]
 param()
 
 BeforeDiscovery {
@@ -176,4 +177,49 @@ Describe 'Examples Script Headers' {
         }
     }
 
-}
\ No newline at end of file
+}
+
+
+Describe 'Check for Duplicate Function Definitions' {
+    BeforeAll { $path = $PSCommandPath
+        $src = (Split-Path -Parent -Path $path) -ireplace '[\\/]tests[\\/]unit', '/src/'
+        # Retrieve all function definitions from the module files
+        $functionNames = @()
+        $moduleFiles = Get-ChildItem -Path $src -Recurse -Include '*.ps1', '*.psm1'
+
+        foreach ($file in $moduleFiles) {
+            $content = Get-Content -Path $file.FullName
+
+            foreach ($line in $content) {
+                # Match function definitions (e.g., "function MyFunction {")
+                if ($line -match 'function\s+([^\s{]+)\s*{') {
+                    $functionName = $Matches[1]
+                    $functionNames += [PSCustomObject]@{
+                        FunctionName = $functionName
+                        FilePath     = $file.FullName
+                        LineNumber   = [array]::IndexOf($content, $line) + 1
+                    }
+                }
+            }
+        }
+
+        # Group by function name and check for duplicates
+        $duplicates = $functionNames | Group-Object -Property FunctionName | Where-Object { $_.Count -gt 1 }
+
+        # Additional information in case of failure
+        if ($duplicates) {
+            Write-host 'The following functions have multiple definitions:'
+            foreach ($group in $duplicates) {
+                Write-host "Function: $($group.Name)"
+                foreach ($func in $group.Group) {
+                    Write-host " - File: $($func.FilePath), Line: $($func.LineNumber)"
+                }
+            }
+        }
+    }
+    It 'should not have duplicate function definitions' {
+        $duplicates.Count | Should -Be 0
+    }
+
+
+}

From 886c7221bd9803fd24da9909ecb50fdd43e35d91 Mon Sep 17 00:00:00 2001
From: mdaneri <max.daneri@broadcom.com>
Date: Mon, 30 Sep 2024 18:08:36 -0700
Subject: [PATCH 2/2] Update _.Tests.ps1

---
 tests/unit/_.Tests.ps1 | 45 ++++++++++++++++++++++++++----------------
 1 file changed, 28 insertions(+), 17 deletions(-)

diff --git a/tests/unit/_.Tests.ps1 b/tests/unit/_.Tests.ps1
index 53bc5a14d..e044818a9 100644
--- a/tests/unit/_.Tests.ps1
+++ b/tests/unit/_.Tests.ps1
@@ -184,42 +184,53 @@ Describe 'Check for Duplicate Function Definitions' {
     BeforeAll { $path = $PSCommandPath
         $src = (Split-Path -Parent -Path $path) -ireplace '[\\/]tests[\\/]unit', '/src/'
         # Retrieve all function definitions from the module files
-        $functionNames = @()
+        $functionNames = @{}
+        $duplicatedFunctionNames = @{}
         $moduleFiles = Get-ChildItem -Path $src -Recurse -Include '*.ps1', '*.psm1'
 
         foreach ($file in $moduleFiles) {
             $content = Get-Content -Path $file.FullName
-
+            $lineNumber = 0
             foreach ($line in $content) {
+                # Increment line number for accurate tracking
+                $lineNumber++
                 # Match function definitions (e.g., "function MyFunction {")
                 if ($line -match 'function\s+([^\s{]+)\s*{') {
                     $functionName = $Matches[1]
-                    $functionNames += [PSCustomObject]@{
-                        FunctionName = $functionName
-                        FilePath     = $file.FullName
-                        LineNumber   = [array]::IndexOf($content, $line) + 1
+
+                    # Check if function name already exists
+                    if (! $functionNames.ContainsKey($functionName)) {
+                        $functionNames[$functionName] = @{
+                            FunctionName = $functionName
+                            FilePath     = @( )
+                            LineNumber   = @( )
+                        }
                     }
+                    else {
+                        # Add to duplicated function names if not already tracked
+                        $duplicatedFunctionNames[$functionName] = $functionNames[$functionName]
+                    }
+                    # Update the function details
+                    $functionNames[$functionName].LineNumber += $lineNumber
+                    $functionNames[$functionName].FilePath += $file.FullName
                 }
             }
         }
 
-        # Group by function name and check for duplicates
-        $duplicates = $functionNames | Group-Object -Property FunctionName | Where-Object { $_.Count -gt 1 }
-
         # Additional information in case of failure
-        if ($duplicates) {
+        if ($duplicatedFunctionNames.Count -gt 0) {
             Write-host 'The following functions have multiple definitions:'
-            foreach ($group in $duplicates) {
-                Write-host "Function: $($group.Name)"
-                foreach ($func in $group.Group) {
-                    Write-host " - File: $($func.FilePath), Line: $($func.LineNumber)"
+            foreach ($key in $duplicatedFunctionNames.Keys) {
+                Write-host "Function: $($key)"
+                for ($i = 0; $i -lt $duplicatedFunctionNames[$key].LineNumber.Count ; $i++) {
+                    Write-host " - File: $($duplicatedFunctionNames[$key].FilePath[$i]), Line: $($duplicatedFunctionNames[$key].LineNumber[$i])"
                 }
             }
         }
     }
+
     It 'should not have duplicate function definitions' {
-        $duplicates.Count | Should -Be 0
+        # Assert no duplicate function definitions
+        $duplicatedFunctionNames.Count | Should -Be 0
     }
-
-
 }