From efdcea148ebc5994135dcfffcbd67781241054d4 Mon Sep 17 00:00:00 2001
From: Aly Badr <aly.badr@rero.ch>
Date: Wed, 18 Nov 2020 08:50:40 +0100
Subject: [PATCH] holdings: remove extra titles for some fields in editor

Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes #1452
* Closes #1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
---
 .../jsonschemas/holdings/holding-v0.0.1.json    | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/rero_ils/modules/holdings/jsonschemas/holdings/holding-v0.0.1.json b/rero_ils/modules/holdings/jsonschemas/holdings/holding-v0.0.1.json
index 5b69ef2daa..4e7efa6177 100644
--- a/rero_ils/modules/holdings/jsonschemas/holdings/holding-v0.0.1.json
+++ b/rero_ils/modules/holdings/jsonschemas/holdings/holding-v0.0.1.json
@@ -55,7 +55,6 @@
       ],
       "properties": {
         "$ref": {
-          "title": "Circulation type URI",
           "type": "string",
           "pattern": "^https://ils.rero.ch/api/item_types/.*?$",
           "form": {
@@ -74,7 +73,6 @@
       ],
       "properties": {
         "$ref": {
-          "title": "Location URI",
           "type": "string",
           "pattern": "^https://ils.rero.ch/api/locations/.+?$",
           "form": {
@@ -108,7 +106,6 @@
         "additionalProperties": false,
         "properties": {
           "uri": {
-            "title": "URI",
             "type": "string",
             "format": "uri"
           },
@@ -440,20 +437,26 @@
       ],
       "properties": {
         "$ref": {
+          "title": "Vendor URI",
           "type": "string",
           "pattern": "^https://ils.rero.ch/api/vendors/.*?$",
           "form": {
+            "focus": true,
+            "remoteOptions": {
+              "type": "vendors"
+            },
             "expressionProperties": {
               "templateOptions.required": "false"
             },
-            "remoteOptions": {
-              "type": "vendors"
+          "placeholder": "Choose a vendor",
+            "templateOptions": {
+              "label": ""
             }
           }
         }
       }
     },
-    "enumerationAndChronology": {
+      "enumerationAndChronology": {
       "title": "Available collection",
       "description": "Textual description of the basic bibliographic unit of the holding.",
       "type": "string",
@@ -581,4 +584,4 @@
       }
     }
   }
-}
\ No newline at end of file
+}