Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular Plugin Manager #234

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hexiro
Copy link

@hexiro hexiro commented Oct 9, 2022

Allows for modularly adding plugins (game wrappers) to PyBoy. This is helpful so users can create their own game wrappers and add them without them having to be officially supported.

There are still some Cython type definition things missing as that's not my specialty, but besides that, I'd like to hear your thoughts.

P.S. my code formatter accidentally added some spaces between plus signs, so if you have an auto code formatter, you might want to run it on this branch.

@hexiro
Copy link
Author

hexiro commented Oct 9, 2022

I see that coincidentally, you opened a PR with a similar goal 2 hours ago. I just opened this because I never finished it and I was organizing my repos (deleting my forks) so I figured I'd open this. If this doesn't get merged that's okay but I hope it can help serve as a reference for what you're doing :)

@hexiro hexiro marked this pull request as ready for review October 9, 2022 00:45
@Baekalfen
Copy link
Owner

Thank you! This is actually really helpful. It's interesting now that we have made two different approaches at the same thing. I think I can steal some of your ideas, and improve mine. I'll be sure to give you a ping and set you as co-author on the commit if I do :)

@hexiro
Copy link
Author

hexiro commented Oct 9, 2022

sounds good! glad it can be of use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants