Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAH-1620 - | Rohit | - Adds OT: Full Access role for superman user #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rohit-yawalkar
Copy link
Contributor

@rohit-yawalkar rohit-yawalkar commented Jul 26, 2022

This PR is about:

  • Adding migration to add OT role to superman
  • Adds relativeToChangelogFile=true argument to include file tag to make xmls searchable

@mohan-13
Copy link
Member

We would not be running liquibase migrations from default-config. And also this migration will error when this gets executed before superman user is created. May be can we move this to the place (bahmni-core) where superman user is created ?

@rohit-yawalkar
Copy link
Contributor Author

rohit-yawalkar commented Jul 27, 2022

We would not be running liquibase migrations from default-config. And also this migration will error when this gets executed before superman user is created. May be can we move this to the place (bahmni-core) where superman user is created ?

@mohan-13, for community purpose who just want to try hands on OT, we can keep this commit and as we are not including default_config migrations in distro, this will not throw any exception. What do you think?

@mohan-13
Copy link
Member

We would not be running liquibase migrations from default-config. And also this migration will error when this gets executed before superman user is created. May be can we move this to the place (bahmni-core) where superman user is created ?

@mohan-13, for community purpose who just want to try hands on OT, we can keep this commit and as we are not including default_config migrations in distro, this will not throw any exception. What do you think?

That's fair. Shouldn't we include this in bahmni-core so that the access is consistent across implementations. This would be generic need for superman user irrespective of how we deploy.

@gsluthra
Copy link
Contributor

I am hesitant to add this in bahmni-core, because this means core assumes OT module to be present, whereas dependency on core is of OT module.. and not the other way around.

If this is added only in default-config, then other configs will need to do this themselves. I guess that is fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants