Update readme.md #10
Merged
Update readme.md #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve docs link
0xcharly
pushed a commit
that referenced
this pull request
Jul 2, 2022
* Add Montex V2 (#10) * Update readme.md * Update rules.mk * Update config.h * Update keyboards/idobao/montex/v2/config.h Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/idobao/montex/v2/rules.mk Add Layouts Co-authored-by: Drashna Jaelre <drashna@live.com> * Merged code fron work done with @vinorodrigues * Update keyboards/idobao/montex/v2/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/idobao/montex/v2/v2.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/idobao/montex/v2/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Removing via_nug keymap * update to montex code (#11) * remove VIA_QMK_RGBLIGHT_ENABLE * more data driven config, simple copyright headers, some code cleanup Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Vino Rodrigues <366673+vinorodrigues@users.noreply.github.com>
0xcharly
pushed a commit
that referenced
this pull request
Jul 4, 2022
* Add Montex V2 (#10) * Update readme.md * Update rules.mk * Update config.h * Update keyboards/idobao/montex/v2/config.h Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/idobao/montex/v2/rules.mk Add Layouts Co-authored-by: Drashna Jaelre <drashna@live.com> * Merged code fron work done with @vinorodrigues * Update keyboards/idobao/montex/v2/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/idobao/montex/v2/v2.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/idobao/montex/v2/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Removing via_nug keymap * update to montex code (#11) * remove VIA_QMK_RGBLIGHT_ENABLE * more data driven config, simple copyright headers, some code cleanup Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Vino Rodrigues <366673+vinorodrigues@users.noreply.github.com>
|
Thanks for the PR! And sorry it took so long to review, I did not receive a notification for this. Feel free to ping me on the Discord server if that happens again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original linked docs file missed the step on how to install qmk. Without it, I couldn't run
qmk, and gotcommand not found. The docs linked in this PR includes how to install qmk, so that you can runqmk compileand what not. Additionally, the newly linked doc is easier to read (as it uses tabs for selecting your OS)