Split hand pin change for splinky v3 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xcharly
reviewed
Nov 8, 2022
0xcharly
requested changes
Nov 8, 2022
Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
|
No problem! I will do those as well. |
0xcharly
added a commit
that referenced
this pull request
Nov 9, 2022
Fix split-hand pin hint for boards supporting v2 an v3 of the Splinky Co-authored-by: Simian <alex@Mandelbrot> Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
0xcharly
added a commit
that referenced
this pull request
Nov 9, 2022
Fix split-hand pin hint for boards supporting v2 an v3 of the Splinky Co-authored-by: Simian <alex@Mandelbrot> Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
0xcharly
added a commit
that referenced
this pull request
Nov 14, 2022
Fix split-hand pin hint for boards supporting v2 an v3 of the Splinky Co-authored-by: Simian <alex@Mandelbrot> Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
0xcharly
added a commit
that referenced
this pull request
Nov 17, 2022
Fix split-hand pin hint for boards supporting v2 an v3 of the Splinky Co-authored-by: Simian <alex@Mandelbrot> Co-authored-by: Charly Delay <0xcharly@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the MASTER_RIGHT and the commented-out code for the SPLIT_HAND_PIN and SPLIT_HAND_PIN_LOW_IS_LEFT to the respective v2 v3 config.h files as the pin was changed from v2 to v3.