Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation dialog on server deletion in iOS client #1767

Closed
wants to merge 3 commits into from
Closed

Confirmation dialog on server deletion in iOS client #1767

wants to merge 3 commits into from

Conversation

CoBC
Copy link
Contributor

@CoBC CoBC commented Feb 17, 2023

Fixes #1766

@CoBC CoBC added this to the TeamTalk v5.13 milestone Feb 17, 2023
@CoBC CoBC requested a review from bear101 February 17, 2023 09:19
@bear101 bear101 marked this pull request as draft February 17, 2023 19:45
@bear101
Copy link
Contributor

bear101 commented Feb 17, 2023

It does not compile. Also note that UIAlertView was deprecated in iOS 9.0

@CoBC
Copy link
Contributor Author

CoBC commented Feb 17, 2023

OK, I made another try. Unfortunately I cannot test myself so I hope this one work better :)

@bear101
Copy link
Contributor

bear101 commented Feb 17, 2023

It also does not compile... :(

@CoBC
Copy link
Contributor Author

CoBC commented Feb 17, 2023 via email

@bear101
Copy link
Contributor

bear101 commented Feb 17, 2023

/Users/bdr/tt5dist/TeamTalk5_iOS/TeamTalk5/Client/iTeamTalk/iTeamTalk/ServerListViewController.swift:303:13 Cannot find 'confirmationDialog' in scope
/Users/bdr/tt5dist/TeamTalk5_iOS/TeamTalk5/Client/iTeamTalk/iTeamTalk/ServerListViewController.swift:305:15 Cannot find 'Button' in scope
/Users/bdr/tt5dist/TeamTalk5_iOS/TeamTalk5/Client/iTeamTalk/iTeamTalk/ServerListViewController.swift:311:15 Cannot find 'Text' in scope

@bear101
Copy link
Contributor

bear101 commented Feb 19, 2023

It still does not compile. Please only make pull requests that has been tested prior to submission.

@CoBC
Copy link
Contributor Author

CoBC commented Feb 26, 2023

Unable to test for now. I'm trying to find a way to build iOS client :)
So, maybe try again later.

@CoBC CoBC closed this Feb 26, 2023
@CoBC CoBC deleted the issue-1766 branch February 26, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bear101 bear101 Awaiting requested review from bear101

Assignees
No one assigned
Labels
enhancement iTeamTalk
Projects
None yet
Milestone
TeamTalk v5.13
Development

Successfully merging this pull request may close these issues.

Add confirmation before server deletion on iOS
2 participants
@CoBC @bear101