Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🟢 🎨 UI Design for the text box that displays contributors text #48

Closed
XanderRubio opened this issue Aug 30, 2023 · 8 comments · Fixed by #52, #59 or #64
Closed

🟢 🎨 UI Design for the text box that displays contributors text #48

XanderRubio opened this issue Aug 30, 2023 · 8 comments · Fixed by #52, #59 or #64
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed user interface Improving design

Comments

@XanderRubio
Copy link
Member

XanderRubio commented Aug 30, 2023

Problem:

Great feedback from the contributor @ccelest1 on how the rainbow text background can be distracting. It would be ideal if either people decide what color they can have for the background of the text or if it can be changed to a more neutral and pleasing color scheme. After thinking of this more, it would be ideal for theming the text box after the Before I Die Wall Project.

This requires UI research to see what displays are best, in addition to considering changing the use of the emojis. It could be better suited from a design view only to have the text "Before I Die..." and the contributors before I die text. This project can be modeled after the Before I Die Wall Project, where the textbox is of a similar black wall chalkboard with the following image and the idea of using various different randomized chalk text color for contributors' text they share for what they want to do before they die. Additionally, another thought is to customize the "Before I Die" bold text that is found in the CSS on line 165 of the MasonryBox.module.css and have that automatically be displayed and translated to a different language depending on where the contributor is contributing from. This would be another issue to create.

You would need to edit in the MasonryBox file editing the React.jsx and CSS.

Please work on the branch feature-48 for this issue.

Image of what a Before I Die Wall looks like ⬇️
Screenshot 2023-08-31 at 01 13 45

For more ideas, view the Beofore I Die Toolkit material below ⬇️
Before I Die Guide.pdf
Before I Die column.pdf
Before I Die large title.pdf

Current layout ⬇️

Screenshot 2023-08-30 at 23 27 28

Resources for ideas 📚:

  • Chalkboard Repo potential idea

  • Check out the codepen for this repo as the background of the chalkboard could be good to use for the text box instead of the blue and yellow rainbow box

Screenshot 2023-08-30 at 23 55 04
@XanderRubio XanderRubio added good first issue Good for newcomers help wanted Extra attention is needed user interface Improving design labels Aug 30, 2023
XanderRubio added a commit that referenced this issue Aug 30, 2023
@negar-75
Copy link
Contributor

Hello XanderRubio,

I'm excited to dive into open-source contributions for the first time. Can you provide more details about the issue I'll be working on? I'm eager to learn and participate. Thank you!

@XanderRubio
Copy link
Member Author

XanderRubio commented Aug 31, 2023

Hi @negar-75,

I appreciate your enthusiasm for jumping into open source and thank you for taking the time to write. I see you are based out of Lisbon, and I was just in Porto 🇵🇹 and Viana do Castelo this past weekend. I see you are experienced as a frontend developer specializing in HTML, CSS, and Javascript, so that this issue would be perfect for your design abilities. I would recommend the following to assist in this issue and project to start with Negar.

  1. Read the README to understand the project and the purpose of it. Then begin on Issue 5.
  2. Read the CONTRIBUTION-GUIDELINES and take time to think about what you want to do before you die and share that in text and image to the JSON file. Also while doing this you will learn quickly how the git workflow works. And I'm more than happy to assist further.
  3. Work on enhancing the UI for this issue, and I would like to get your feedback on what you believe is a good design option that can match the Before I Die Wall project for a theme of design.

Please let me know if I can help you further. Please confirm if you would like this issue #48 assigned so no one else will work on it.

Have a nice day!

Xander

@negar-75
Copy link
Contributor

I definitely want to do it!
Thanks for your precise explanation!
If I have more questions I will come back to you!

@XanderRubio
Copy link
Member Author

Excellent @negar-75! I will assign you this task now😉 Have a nice day!

@negar-75
Copy link
Contributor

negar-75 commented Sep 2, 2023

Hi @XanderRubio
I did some changes in Masonry box according the things that I understood from explanation

@XanderRubio
Copy link
Member Author

HI @negar-75

Great, I will take a look at your #52 pull request. I see that you have been busy working on 7 different files. Well done! I look forward to reviewing your work.

@XanderRubio XanderRubio linked a pull request Sep 2, 2023 that will close this issue
XanderRubio added a commit that referenced this issue Sep 4, 2023
XanderRubio added a commit that referenced this issue Sep 4, 2023
XanderRubio added a commit that referenced this issue Sep 4, 2023
@XanderRubio XanderRubio reopened this Sep 4, 2023
@XanderRubio
Copy link
Member Author

We almost have this issue closed. We just need to revisit a formatting issue with how the contributor's bid images are displayed to the left on the webpage.

Screenshot 2023-09-04 at 16 56 14

@XanderRubio XanderRubio mentioned this issue Sep 4, 2023
@XanderRubio XanderRubio linked a pull request Sep 5, 2023 that will close this issue
XanderRubio added a commit to negar-75/BeforeIDieAchievements that referenced this issue Sep 6, 2023
negar-75 added a commit to negar-75/BeforeIDieAchievements that referenced this issue Sep 6, 2023
@XanderRubio XanderRubio linked a pull request Sep 6, 2023 that will close this issue
@XanderRubio XanderRubio mentioned this issue Sep 6, 2023
@XanderRubio
Copy link
Member Author

The feature has been successfully created and added. Thank you to @negar-75. Thank you!!!!Glowing Star

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed user interface Improving design
Projects
None yet
2 participants