Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#185 Update font family Chalk_3 to title BID #186

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

DiguyaDeveloper
Copy link
Contributor

@DiguyaDeveloper DiguyaDeveloper commented Oct 12, 2023

Issue Addressed

  • Updated the font family of the bid-text class
  • Updated ternary if syntax

Proposed Changes and Benefits

Screenshots

image

Notes to Reviewers

I change syntax of HTML element of BID-TEXT to dont repeat code.
Please, send to hacktoberfets this pull request

Checklist

  • I have thoroughly read and understand The Contribution Guidelines.
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior.
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc.
    • Fix - bug fixes.
    • Docs - fixing typos and adding new content.
  • I have listed my proposed changes and their benefits.
  • I have linked the corresponding issue in the Issues section.

@vercel
Copy link

vercel bot commented Oct 12, 2023

@DiguyaDeveloper is attempting to deploy a commit to the Before I Die Code Team on Vercel.

A member of the Team first needs to authorize it.

@DiguyaDeveloper
Copy link
Contributor Author

@XanderRubio Can you review my pull request? I need add my profile in contributors?

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 11:23am

Copy link
Member

@XanderRubio XanderRubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiguyaDeveloper Well done! I have reviewed your code on the preview link and it looks great! Excellent work and I will be going ahead with merging your contribution into the main. And thank you for your detailed pull request write-up, it is very much appreciated!

@XanderRubio XanderRubio merged commit eca0df1 into BeforeIDieCode:main Oct 12, 2023
1 check passed
@XanderRubio
Copy link
Member

XanderRubio commented Oct 12, 2023

@XanderRubio Can you review my pull request? I need add my profile in contributors?

Yes, @DiguyaDeveloper, please go ahead and add what you want to do before you die with text and image by following issue #5, and in the process, you will add yourself to the contributors list. Great work as it is much appreciated! Have a great day, Diego!

Xander

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants