Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Router.set_model_list & Avoid overwriting litellm_params #706

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix Router.set_model_list & Avoid overwriting litellm_params #706

merged 1 commit into from
Oct 30, 2023

Conversation

mc-marcocheng
Copy link
Contributor

  1. self.model_names was not updated when model_list is updated through set_model_list
  2. Prevent modifying litellm_params in the model_list
  3. Many extra whitespaces are in the script, my IDE automatically trims them.

@vercel
Copy link

vercel bot commented Oct 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 7:36am

@krrishdholakia
Copy link
Contributor

lgtm!

@krrishdholakia krrishdholakia merged commit 6e454a6 into BerriAI:main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevkar sevkar sevkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mc-marcocheng @krrishdholakia @sevkar