Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug for the case --model is not specified #781

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

clalanliu
Copy link
Contributor

When you following instruction to use a config.yaml file, you will not specify --model when you launch the server, and you will get error even with config file detected:

CONFIG FILE DETECTED
data: {'model': 'huggingface/some_model', 'messages': [{'role': 'user', 'content': 'How are you?'}], 'max_tokens': 150}
Traceback (most recent call last):
  File "/app/main.py", line 110, in chat_completion
    server_settings.get("completion_model", None) # server default
AttributeError: 'NoneType' object has no attribute 'get'

Not sure whether we should always specify server_settings in config.yaml.

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 4:03pm

Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ishaan-jaff
Copy link
Contributor

thanks for the contribution - would love to give you a shoutout on our daily changelog what's your linkedin / twitter @clalanliu ?

@ishaan-jaff ishaan-jaff merged commit 8cedacf into BerriAI:main Nov 8, 2023
1 of 2 checks passed
@clalanliu
Copy link
Contributor Author

thanks for the contribution - would love to give you a shoutout on our daily changelog what's your linkedin / twitter @clalanliu ?

This is my linkedin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants