Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NYSenate Links no longer work #89

Closed
lavingiasa opened this issue Aug 23, 2023 · 8 comments · May be fixed by #91
Closed

NYSenate Links no longer work #89

lavingiasa opened this issue Aug 23, 2023 · 8 comments · May be fixed by #91

Comments

@lavingiasa
Copy link

Steps to reproduce:

Expected behavior:

  • It takes you to the district webpage for district 13

Observed behavior:

I'm not sure when this broke, but this might not be solvable by this tool because the nysenate website seems to be redirecting.

@lavingiasa
Copy link
Author

Note: It does look like the link is being handled somehow because https://www.nysenate.gov/district**s**/28 takes you to a 404, but the district link redirects you.

@evadecker
Copy link
Contributor

Hi @lavingiasa, sorry for the delay here! It does look like district pages on the nysenate.gov site no longer exist, and I wasn't able to find new pages for districts. I filed an issue in the website's repo and we'll see what we hear!

@lavingiasa
Copy link
Author

lavingiasa commented Oct 27, 2023 via email

@routinet
Copy link

routinet commented Oct 27, 2023

Hello again,

I followed up on the issue file in nysenate, but thought you might be interested in an alternative.

NYSenate.gov sources its map data from another of our tools: SAGE (Senate Address Geocoding Engine). For districts, the map is embedded from a call to, e.g., //pubgeo.nysenate.gov/map/senate/29?x=850&y=696&sd=29. In my brief testing, the query string parameters do not seem to be necessary. My colleague guesses they are resolution parameters, and a redundant district marker. In any case, it may be worth your while to go direct to the same source we use.

@evadecker
Copy link
Contributor

Thanks @routinet! We already have the geojson for displaying senate boundaries on the map; what we're missing is a page that displays information about that district, who the senator is, etc.

@evadecker
Copy link
Contributor

@lavingiasa A fix was merged into nysenate.gov: nysenate/NYSenate.gov-Website-D9#46 and the links for Senate Districts are available once again! 🎉

senate-links.mov

@lavingiasa
Copy link
Author

lavingiasa commented Nov 14, 2023 via email

@evadecker
Copy link
Contributor

Of course! Thanks for reporting it and please file issues for any other problems you come across or requests for improvements :)

@zhik zhik closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants