Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add circleci for publishing a preview version #1547

Merged
merged 2 commits into from
Feb 19, 2022
Merged

add circleci for publishing a preview version #1547

merged 2 commits into from
Feb 19, 2022

Conversation

Cyrik
Copy link
Member

@Cyrik Cyrik commented Feb 19, 2022

What has Changed?

  • added marketplace-preview-publish job to circle-ci

VSCode recently added pre-release versions of extensions. This would be great for our dev branch. The (docs)[https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions]

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
    • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension or run npm run eslint).

Ping @PEZ, @bpringe

@Cyrik
Copy link
Member Author

Cyrik commented Feb 19, 2022

I'm not well versed in circleci configs and I don't fully understand your setup, but I think this should work?

@PEZ PEZ merged commit 5193e82 into BetterThanTomorrow:dev Feb 19, 2022
@PEZ
Copy link
Collaborator

PEZ commented Feb 19, 2022

I think it will work. Pretty exciting stuff!

@PEZ
Copy link
Collaborator

PEZ commented Feb 20, 2022

Well, something went wrong.

image

https://app.circleci.com/pipelines/github/BetterThanTomorrow/calva/4448/workflows/323885d4-341d-4c66-9145-249c58c45e7e/jobs/18121

 ERROR  Cannot use '--pre-release' flag with a package that was not packaged as pre-release. Please package it using the '--pre-release' flag and publish again.

Maybe this job shouldn't run in the release workflow? Seems better to wait until after this workflow when dev version is bumped.

@PEZ
Copy link
Collaborator

PEZ commented Feb 20, 2022

However, that workflow isn't being run from this bump:

image

I wonder what's up with that? You have any ideas, @bpringe ?

@Cyrik
Copy link
Member Author

Cyrik commented Feb 21, 2022

@PEZ Yeah this shouldn't run on release, it should run on merge into dev, but I'm not sure how to do that in your flow 😅

@PEZ
Copy link
Collaborator

PEZ commented Feb 21, 2022

Almost there!

image

Fails because the marketplace does not support semver pre-release tags:

image

There's an issue about it here: microsoft/vsmarketplace#310

I'm disabling it for now, like so:

image

Let's keep track of that issue. Hopefully they'll come to their senses about this. Otherwise, maybe we can use murmurmhash3 to create a number from our tag.

@Cyrik
Copy link
Member Author

Cyrik commented Feb 21, 2022

Ah interesting about the semver. I saw it mentioned in the docs already. I thought they "don't support it" in the sense of: we don't handle them as special, not that they just blow up...

@PEZ
Copy link
Collaborator

PEZ commented Feb 21, 2022

Tracking this issue here now, btw: #1554

@bpringe
Copy link
Member

bpringe commented Feb 23, 2022 •
edited
Loading

However, that workflow isn't being run from this bump

@PEZ The bump adds "[skip ci]" to the commit message to skip that workflow. Does that answer your question or was it about something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cyrik @PEZ @bpringe