Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active linenumber colour highlighting property - and vim relative numbering highlights #487

Closed
irisida opened this issue Nov 22, 2020 · 12 comments

Comments

@irisida
Copy link

irisida commented Nov 22, 2020

Describe what you want
I would like to have the ability to use/set the "editorLineNumber.activeForeground": "#fffff" property. This would be exceptionally useful for vim mode users with relative line numbering which is a key part of the workflow for many.

The expected outcome would be that the current line and highlighting of the theme allows for default or user-selected highlight colour that differentiates from the other lines of the file and their respective line numbering.

Additional context
attached a screenshot showing the relative numbering setup and hopefully, it demonstrates why the highlighting would be useful.

An even further incredible addition/extension to above would be to be able to highlight the tenth line either side with a different colour too. Or all multiples of ten thereafter, as an additional visual/cognitive easing. But it's probably most useful to people with a relative line numbering setup so may not be as mainstream as the first part of the request for the current line number highlight.
onedarkprolines

@yh-sb
Copy link

yh-sb commented Nov 25, 2020

Looks like this commit cause the following line number coloring:

Screenshot at 2020-11-25 10:20:43

I think that such coloring doesn't fit for OneDarkPro theme, does it?

@ghost
Copy link

ghost commented Nov 25, 2020

#fffff instead of #ffffff

image

@Binaryify
Copy link
Owner

will fix it soon~

@irisida
Copy link
Author

irisida commented Nov 25, 2020

Thanks. Not a deal-breaker at all, but it's a very useful addition for that mode/workflow.

Much appreciated.

@ghost
Copy link

ghost commented Nov 25, 2020

The selected color is too bright and distracting:

image

I'll fix it in my User Settings, but I still think you should have used something like #abb2bf:

image

@yh-sb
Copy link

yh-sb commented Nov 25, 2020

Maybe #999999 ?

@Binaryify
Copy link
Owner

Binaryify commented Nov 25, 2020

@r44083 i think #abb2bf is better, but user still can use custom color

@irisida
Copy link
Author

irisida commented Nov 25, 2020

Definitely better to allow custom colour.

@Binaryify
Copy link
Owner

just release a new version~

@irisida
Copy link
Author

irisida commented Nov 25, 2020

updated to 3.9.11

Still doesn't show up. I'm afraid. Also removed my initial override in case that was cancelling it. No joy thus far. Have restarted VSC twice.
Screenshot 2020-11-25 at 10 15 21

@Binaryify
Copy link
Owner

@irisida did you set editor.renderLineHighlight to "all"

@irisida
Copy link
Author

irisida commented Nov 25, 2020

I hadn't no. I have now and hey presto! It's even more fabulous than I'd hoped.

Thank you! (starred the repo. You people are all kinds of awesome)

@irisida irisida closed this as completed Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants