Merge pull request #1399 from SpadesA99/SpadesA99-patch-1

Fix the process handle leak when using ps command on Windows
BishopFox · Sep 1, 2023 · f32d9a9 · f32d9a9
2 parents f623b0c + f9c5dae
commit f32d9a9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/implant/sliver/ps/ps_windows.go b/implant/sliver/ps/ps_windows.go
@@ -124,10 +124,14 @@ func getProcessOwner(pid uint32) (owner string, err error) {
 	if err != nil {
 		return
 	}
+	defer syscall.CloseHandle(handle)
+
 	var token syscall.Token
 	if err = syscall.OpenProcessToken(handle, syscall.TOKEN_QUERY, &token); err != nil {
 		return
 	}
+	defer token.Close()
+
 	tokenUser, err := getTokenOwner(token)
 	if err != nil {
 		return