Address Microsoft feedback #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Added Tableau Connector to OpenSearch SQL
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Added CEILING and FLOOR functions
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
…g unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
…ifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Dialect: Added CAST to convert to int and string as of AOS-202
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Dialect changes for exprtests
Dialect: fix return type for MID function as part of AOS-202
Dialect: fixes math.hexbin function as of AOS-195
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Update Company Name as of AOS-231
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Update Vendor Name as of AOS-231
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Add TDVT test result and a readme file
Pull most recent changes from the upstream project
* Added option for Hostname Verification for PBI connector Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed Beta to false and updated screenshots on the readme files Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Bump connector version and add CHANGELOG Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Improved changelog message for 1.0.1 PBI connector Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated PBIDS Handler for the connector Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
ghost
requested review from
jduo,
kylepbit,
Yury-Fridlyand,
raymond-lum,
alexmeizer and
MaxKsyunz
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
=========================================
Coverage 99.92% 99.92%
Complexity 2698 2698
=========================================
Files 257 257
Lines 6491 6491
Branches 402 402
=========================================
Hits 6486 6486
Misses 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
MaxKsyunz
approved these changes
Mar 8, 2022
alexmeizer
approved these changes
Mar 8, 2022
jduo
reviewed
Mar 8, 2022
| @@ -82,7 +82,11 @@ OpenSearchProjectImpl = (Server as text, Port as number, UseSSL as logical, Host | |||
| ConnectionString = [ | |||
| Driver = "OpenSearch SQL ODBC Driver", | |||
| Host = FinalServerString, | |||
| HostnameVerification = if HostnameVerification then 1 else 0 | |||
| HostnameVerification = | |||
| if HostnameVerification = null or HostnameVerification then | |||
There was a problem hiding this comment.
I think you can use the ? operator to check for nullity + get the value.
There was a problem hiding this comment.
Does there need to be a change for PBIDS files to specify this option?
| @@ -28,7 +28,7 @@ OpenSearchProjectType = type function ( | |||
| Documentation.FieldDescription = "Use SSL", | |||
| Documentation.AllowedValues = { true, false } | |||
| ]), | |||
| HostnameVerification as (type logical meta [ | |||
| optional HostnameVerification as (type logical meta [ | |||
There was a problem hiding this comment.
Have you tested opening PBIDS files generated with the latest connector to see if they work if the optional parameter is not given a value?
There could also be issues with TestConnection as it is expecting HostnameValidation to be set. You need to test with Gateway to confirm.
Yury-Fridlyand
approved these changes
May 4, 2022
Yury-Fridlyand
force-pushed
the
main
branch
from
4effd7d to
3ca6450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a PBI connector issue found when a fix to an ssl issue was being resolved. The solution to the connector issue was to create a Certificate Validation option for users specified in PR 449. Microsoft came back with the feedback saying "It appears the update is adding a new required parameter the data source function signatures, which also makes it part of the credential path. This would be a breaking change for existing queries and existing credentials.".
The solution in this PR is to make Certificate Validation optional with a default of true when no option is selected. This adds a parameter to the pbix files made with the old connector and allows to ability to successfully load old pbix files with the proposed changes to the connector.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.