Handle error on command for FFI client + C# example #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested review from
aaron-congo,
jonathanl-bq,
acarbonetto,
Elen-Ghulam and
SanHalacogluImproving
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
force-pushed
the
csharp/dev_yuryf_fix_ut_on_mac
branch
from
1a6e9a7 to
70cc9d9
Compare
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
jonathanl-bq
reviewed
Mar 7, 2024
csharp/lib/src/lib.rs
Outdated
| Err(_) => (client.failure_callback)(callback_index), // TODO - report errors | ||
| Err(err) => { | ||
| logger_core::log_debug("command error", format!("callback {}, error {}, kind {:?}, code {:?}, category {:?}, detail {:?}", callback_index, err, err.kind(), err.code(), err.category(), err.detail())); | ||
| let c_err_str = CString::new(error_message(&err)).expect("CString::new failed"); |
There was a problem hiding this comment.
nit: I don't think we need expect here. We could probably use unwrap instead and it would be just as helpful wrt debug info. Applies throughout.
csharp/lib/src/lib.rs
Outdated
| @@ -118,7 +119,11 @@ pub extern "C" fn set( | |||
| let client = Box::leak(Box::from_raw(ptr_address as *mut Client)); | |||
| match result { | |||
| Ok(_) => (client.success_callback)(callback_index, std::ptr::null()), // TODO - should return "OK" string. | |||
| Err(_) => (client.failure_callback)(callback_index), // TODO - report errors | |||
| Err(err) => { | |||
| logger_core::log_debug("command error", format!("callback {}, error {}, kind {:?}, code {:?}, category {:?}, detail {:?}", callback_index, err, err.kind(), err.code(), err.category(), err.detail())); | |||
There was a problem hiding this comment.
Doesn't err implement Debug or Display? I think we should be able to just print it without explicitly extracting the kind, code, category, and detail.
aaron-congo
approved these changes
Mar 7, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should go together with #114 to
glide-ffiNote: no error handling on connection [yet]