-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFI connection without protobuf + C# #126
base: csharp/integ_yuryf_connection
Are you sure you want to change the base?
FFI connection without protobuf + C# #126
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Clean(); // memory leak protection on rebuilding a config from the builder | ||
built = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this stuff is not thread safe, but I assume it is ok
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
csharp/lib/src/connection.rs
Outdated
use std::ffi::c_char; | ||
|
||
#[repr(C)] | ||
pub struct ConnectionConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have documentation for the types here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1:1
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Do you know how to add a reference to an arbitrary file by relative path ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't understand where relative path starts from. I tried to point to connection_request.proto
, but all experiments with ../../.. failed
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approval is for the Rust portion of the code. I left some comments on documentation that needs to be updated, but otherwise, this looks fine to me.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Config usage example
Config extended samples