Prepare for release 0.5.0 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
|
|
||
| # 0.5.0 - 2021-10-22 | ||
|
|
||
| - IMPORTANT: Encrypt ECDSA adaptor signatures in release builds. Previously adaptor signatures were NOT encrypted. |
Contributor
There was a problem hiding this comment.
This sounds like we were outputting non-encrypted adaptor signatures (which is not a thing) whereas really we were just returning 62 zero bytes.
I think the fix is important but this description is a bit misleading.
Collaborator
Author
There was a problem hiding this comment.
Good point. Pushed fix attempt.
jonasnick
force-pushed
the
release-0.5.0
branch
from
f30e807 to
582a5a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40