-
Notifications
You must be signed in to change notification settings - Fork 19
rewrite README.md #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite README.md #302
Conversation
|
cc @imaginator @roconnor-blockstream Also cc @sanket1729 @uncomputable in case you have opinions and are willing to take the time to review this. |
0d89271 to
30716ca
Compare
apoelstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On 30716ca successfully ran local tests
sanket1729
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
README.md
Outdated
| This is the official Rust library of the [Simplicity Language](https://simplicity-lang.org/). | ||
|
|
||
| The MSRV of this crate is **1.78.0**. | ||
| Simplicity is a low-level, typeed functional language designed to be a drop-in replacement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not replacement but more like alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I think "drop-in alternative" reads ok. I agree that "replacement" is too agressive a term.
README.md
Outdated
| - cross-validating the C and Rust Bit Machine implementations | ||
|
|
||
| The libsimplicity repository also contains: | ||
| - A Haskell library with similar goals to rust-simplicity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is not wrong, I think it is better to have folks think of the Haskell library as a reference implementation instead. Indeed we generate some Rust code from this reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, updated.
30716ca to
3b62bdf
Compare
roconnor-blockstream
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
| This is the official Rust library of the [Simplicity Language](https://simplicity-lang.org/). | ||
|
|
||
| The MSRV of this crate is **1.78.0**. | ||
| Simplicity is a low-level, typeed functional language designed to be a drop-in alternative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/typeed/typed
|
LGTM, other than that one typo. |
With suggestions and rewording from Claude 4.
3b62bdf to
c8602cf
Compare
|
Gonna go ahead and merge this. |
With suggestions and rewording from Claude 4.
The next PR will attempt to fill in the top-level library docs which appear on docs.rs, including more useful simple example programs.