generator: Save a fe_mul in shallue_van_de_woestijne #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Arguably this whole function should be rewritten. Unfortunately that is risky, so maybe it is better to keep doing these micro-improvements. |
roconnor-blockstream
approved these changes
Jan 11, 2024
Contributor
roconnor-blockstream
left a comment
roconnor-blockstream
left a comment
There was a problem hiding this comment.
LGTM
I ran some randomized testing comparing this to my Haskell implementation.
Collaborator
Author
You have a point, though. I mean, sure, let's merge this if we get the ACKs, but a proper rewrite is probably a better approach. |
Collaborator
Author
Is that a full implementation of the SWU map? I guess we could then steal the algorithm. |
Contributor
|
See #286 for my rewrite of this function, which would supersede this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.