Named ctor for empty property lists. #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #786. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 89 89
Lines 5870 5870
=======================================
Hits 5046 5046
Misses 824 824 ☔ View full report in Codecov by Sentry. |
alkino
approved these changes
Dec 19, 2023
1uc
changed the title
Empty property lists have a valid HID, unlike default constructed properties which use H5P_DEFAULT. This only matters when interfacing with HDF5 directly.
1uc
force-pushed
the
1uc/empty-property-list
branch
from
6be624a
to
471ce6d
Compare
matz-e
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty property lists have a valid HID, unlike default constructed properties which use H5P_DEFAULT.
This only matters when interfacing with HDF5 directly.