Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server-provision config to allow loading subset of services/middleware #89

Open
jwsm opened this issue Apr 13, 2017 · 2 comments

Comments

@jwsm
Copy link

jwsm commented Apr 13, 2017

We're proposing a backwards-compatible enhancement to the "server-provisions" feature/config block introduced in #87.

In some cases, a container BOS may wish to only include some subset of services or middleware from a provisioned BOS rather than all. In addition, to avoid naming conflicts you would want to be able to give the provisioned service a mapped name.

In the example below:

  • The config is backwards compatible (if an element is a string, all services/middleware are provisioned, if an object the config is read)
  • In this example, only femaService and emailService are pulled in from provisioned BOS
  • emailService is renamed to myEmailService in the container BOS
"server-provisions": [{
  "package": "sfi-esb",
  "services": [
    "femaService",
    "emailService": {
      "mappedName": "myEmailService"
    }
  ],
  "middleware": [
    ...
  ]
}],
@seanpk
Copy link
Member

seanpk commented Apr 13, 2017

This looks really useful, and provides a solution to one of the concerns that we had with the first implementation: conflicting service and middleware names.

I'd like to suggest a change to the "extended" format, either:
"as" instead of "mappedName"
or
"myEmailService:emailService"

@jwsm
Copy link
Author

jwsm commented Apr 13, 2017

Thanks. I will work on an implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants