-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extraction of CML-CompChem from Gaussian, GAMESS-US and QChem #1
Open
ostueker
wants to merge
237
commits into
master
Choose a base branch
from
workOnCompChem
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The designation '<property dictRef="cc:zeropoint">' was not correct, as the list contains more than just the ZeroPointEnergy. Also resolved ambigous dictRefs of individual terms. See testcase in l716.thermochemistry.energies.xml for new output.
and fixed bug that energies are extracted from "terse" Gaussian output.
* Added support for: G3, G3MP2, G3B3, G3MP2B3, G4 and G4MP2 * Needed to find new markers for the beginning and end of jobs to have the final "Mixed" archive end up in it's own job. * Added a workaround to l9999.molecule.array.xml to enable extracting the coordinates from SP and Mixed operations in the composite methods, as in those the coordinate line includes a freeze-code (0) between the Symbol and the X-coordinate.
1. Terminlology: In the Archive the "forces" are actually gradients (inverted sign). Therefore the dictRef has been corrected from cc:forces to cc:gradients. 2. Bugfix: The arrays with cc:forceConstants and cc:gradients have been pulled-up too far in the xml tree, so that they appeared in the root cml:module.
The Object returned by evaluateValue(fromElement, value) can be a String, int, double or null, where the middle two can't be just casted into a Sting. Just replacing the cast ti Sting by .toString() raises an NPE, when null is returned.
fixed: adding the attributes `spinMultiplicity` and `formalCharge` to `cml:molecule`s
This patch tries to remove extra spaces before parsing the date with JodaTime. see https://bitbucket.org/oliver_stueker/jumbo-converters/issue/3
GAMESS VERSION = 12 JAN 2009 (R1)
…p, cc:press in terse file
…semi-empirical methods
…odules in ROHF and UHF calculations
…in job 2 of rohf calculation
…ital eigenvalues, orbital eigens and density matrices
…f cc:thirdDerivativesMethod for third derivatives method
…module and modules l716 and l601.polariz to finalization child module otherComponents
…ontain table of arrays
…them as attribs to all molecules
…_total in finalization propertyList
…nt to finalization property list, added module cc:multipole to finalization module
…t archive sections from Linux and Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work to improve support of extracting from Gaussian files as well as parsers for GAMESS-US and QChem.