From 1144a6e815222115b71e46924431477daa0cbfb9 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Fri, 17 Jan 2025 16:23:11 -0500 Subject: [PATCH 1/3] Replaced fail_on_error with fail_level in reviewdog action * fail_on_error has been deprecated Signed-off-by: Jared Duffey --- .github/workflows/format_pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/format_pr.yml b/.github/workflows/format_pr.yml index 34901a2c1e..1aeced693c 100644 --- a/.github/workflows/format_pr.yml +++ b/.github/workflows/format_pr.yml @@ -30,4 +30,4 @@ jobs: uses: reviewdog/action-suggester@v1 with: tool_name: clang-format - fail_on_error: true + fail_level: error From 043634a40ee7c776c517f4a8fd21838f20081ed6 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Fri, 17 Jan 2025 16:24:17 -0500 Subject: [PATCH 2/3] Added intentional bad formatting for testing Signed-off-by: Jared Duffey --- src/simplnx/Plugin/AbstractPlugin.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/simplnx/Plugin/AbstractPlugin.cpp b/src/simplnx/Plugin/AbstractPlugin.cpp index 8c4d1a67dd..9aa3fa03f3 100644 --- a/src/simplnx/Plugin/AbstractPlugin.cpp +++ b/src/simplnx/Plugin/AbstractPlugin.cpp @@ -26,6 +26,8 @@ std::string AbstractPlugin::getName() const return m_Name; } + + std::string AbstractPlugin::getDescription() const { return m_Description; From a205f39340e16621ea066410e596ddf99a43d4ec Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Fri, 17 Jan 2025 16:26:06 -0500 Subject: [PATCH 3/3] Revert "Added intentional bad formatting for testing" This reverts commit 043634a40ee7c776c517f4a8fd21838f20081ed6. --- src/simplnx/Plugin/AbstractPlugin.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/simplnx/Plugin/AbstractPlugin.cpp b/src/simplnx/Plugin/AbstractPlugin.cpp index 9aa3fa03f3..8c4d1a67dd 100644 --- a/src/simplnx/Plugin/AbstractPlugin.cpp +++ b/src/simplnx/Plugin/AbstractPlugin.cpp @@ -26,8 +26,6 @@ std::string AbstractPlugin::getName() const return m_Name; } - - std::string AbstractPlugin::getDescription() const { return m_Description;