-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Switch assets based on address/invoice input #374
Comments
Also gets rid of this error where web app should revalidate my liquid address when I am switchin to Liquid: |
unrelated opened a new issue |
try {
const assetName = asset();
decodeAddress(assetName, address);
input.setCustomValidity("");
input.classList.remove("invalid");
setAddressValid(true);
setOnchainAddress(address);
} catch (e) { i dont like it, i think the natural flow is people will choose the asset first and then paste. maybe even people will be confused and trying to send liquid to a btc address and not noticing that the asset magically switched to btc, expecting lbtc to receive. either way i think this optimisation is too much. and currently we validate the address by trying top decode the address with the asset the user selected. |
It is not, I am 100% convinced we want to do this. You don't know the support cases that Michael and I handled where we explained folks to switch the asset to Liquid "because it said invalid address". I see virtually no chance of anyone pasting an liquid address expecting to use mainchain. |
closes #374 add direction switch on invoice paste switch direction on pasting address intop invoice clear invoice and address on asset switch unhardcore prefixes
* feat: switch assets based on address closes #374 add direction switch on invoice paste switch direction on pasting address intop invoice clear invoice and address on asset switch unhardcore prefixes * refactor: asset switch logic prettier * fixup! * remove test * fix: missing notification for LN -> address * test: add tests for asset switch --------- Co-authored-by: michael1011 <me@michael1011.at>
When a Liquid address is entered/scanned, the frontend should switch the receiving symbol the L-BTC. Similar concept for Bitcoin addresses and lightning invoices/lnurls/sat domains
The text was updated successfully, but these errors were encountered: