Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch assets based on address #503

Merged
merged 9 commits into from
Mar 22, 2024
Merged

feat: switch assets based on address #503

merged 9 commits into from
Mar 22, 2024

Conversation

dni
Copy link
Contributor

@dni dni commented Mar 13, 2024

closes #374

switches onchain asset based on address paste

@dni dni requested a review from michael1011 March 13, 2024 08:40
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Mar 22, 2024 2:03pm
webapp-mainnet ✅ Ready (Inspect) Visit Preview Mar 22, 2024 2:03pm

src/utils/compat.ts Outdated Show resolved Hide resolved
src/utils/compat.ts Outdated Show resolved Hide resolved
src/utils/compat.ts Outdated Show resolved Hide resolved
src/components/AddressInput.tsx Outdated Show resolved Hide resolved
@kilrau
Copy link
Member

kilrau commented Mar 19, 2024

I think this branch needs a rebase, I have rootstock dangling in there
image

dni and others added 3 commits March 19, 2024 22:48
closes #374

add direction switch on invoice paste

switch direction on pasting address intop invoice

clear invoice and address on asset switch

unhardcore prefixes
src/i18n/i18n.ts Show resolved Hide resolved
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notification of switch doesn't always show, e.g. here when switching back from lightning to liquid:
Screencast from 03-20-2024 11:39:06 AM.webm

Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Switch assets based on address/invoice input
3 participants