Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user feedback for copy button #516

Merged
merged 6 commits into from
Mar 19, 2024
Merged

feat: add user feedback for copy button #516

merged 6 commits into from
Mar 19, 2024

Conversation

dni
Copy link
Contributor

@dni dni commented Mar 19, 2024

  • add CopyButton component
  • add tests for it

add icons

2024-03-19.13-19-16.mp4

- add CopyButton component
- add tests for it

add icons
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Mar 19, 2024 8:49pm
webapp-mainnet ✅ Ready (Inspect) Visit Preview Mar 19, 2024 8:49pm

@kilrau
Copy link
Member

kilrau commented Mar 19, 2024

Reeeally nice!

Very high-level complaining nad if it's complicated let's not do it, but ideally the copy tick in one button immediately disappears if I press copy in another button to never have the impression I copied multiple things at the same time.

Screencast.from.03-19-2024.05.54.41.PM.webm

Co-authored-by: michael1011 <me@michael1011.at>
@michael1011
Copy link
Member

Very high-level complaining nad if it's complicated let's not do it,

We agreed to not do it

@michael1011 michael1011 merged commit bd1dd61 into main Mar 19, 2024
4 checks passed
@michael1011 michael1011 deleted the copy-button branch March 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants