Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: catch exception on refund page #534

Merged
merged 3 commits into from
Mar 27, 2024
Merged

bug: catch exception on refund page #534

merged 3 commits into from
Mar 27, 2024

Conversation

dni
Copy link
Contributor

@dni dni commented Mar 27, 2024

screenshot-1711526219

happened if status returned a 404, request errors are already logged so do nothing. ps. this should never happen in production :)

happened if status returned a 404, request errors are already logged so do nothing.
@dni dni requested review from michael1011 and kilrau March 27, 2024 08:02
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Mar 27, 2024 9:29am
webapp-mainnet ✅ Ready (Inspect) Visit Preview Mar 27, 2024 9:29am

await getSubmarineTransaction(swap.asset, swap.id);
addToRefundableSwaps(swap);
} catch (_) {
// do nothing, there is already a request error in the console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error of a failed HTTP request, if that happens to be enabled in your browser
Add a warning log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants