Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show qr code icon depending on invoice/onchain asset #559

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

dni
Copy link
Contributor

@dni dni commented Apr 22, 2024

closes #558

screenshot-1713796813
screenshot-1713796809
screenshot-1713796805

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Apr 22, 2024 2:49pm
webapp-mainnet ✅ Ready (Inspect) Visit Preview Apr 22, 2024 2:49pm

Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, LGTM

@kilrau kilrau self-requested a review April 23, 2024 09:04
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm Rootstock doesn't show any QR doesn't it - so not sure why we have qr logos for it.

image

@michael1011 michael1011 merged commit dbf2d08 into main Apr 23, 2024
4 checks passed
@michael1011 michael1011 deleted the feat-qr-icons branch April 23, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI feedback: Boltz icon in QR code confusing when QR contains a Liquid address
3 participants