fix: error on camera permissions denied #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michael1011
reviewed
Jul 14, 2024
dni
commented
Jul 15, 2024
michael1011
force-pushed
the
camera-mobile
branch
from
e149fd0
to
8258e28
Compare
kilrau
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Strings added and tested - looking good. What I do not like is that the "Scan QR Code" button disappears after a failed permission request. One has to refresh the site to get a new try. Just keep the button there please.
Screencast from 07-16-2024 11:39:08 AM.webm
done, can you try again? |
kilrau
approved these changes
Jul 23, 2024
michael1011
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #600
@kilrau translations