Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkEditor - Install based app #2612

Open
4 tasks done
FixeQyt opened this issue Jun 24, 2024 · 4 comments
Open
4 tasks done

SkEditor - Install based app #2612

FixeQyt opened this issue Jun 24, 2024 · 4 comments

Comments

@FixeQyt
Copy link

FixeQyt commented Jun 24, 2024

What is the name of the app?

SkEditor

Where is the app hosted?

https://github.com/SkEditorTeam/SkEditor

About the app

SkEditor is an app for editing Skript files

Upload file or Add PR Link

SkEditor.zip

Confirmations

Copy link
Contributor

A zipfile was found in the body of your issue.
The sha1sum of the zip was: 0e4256e4c097ec45580ce24f8ffa4887bda42c25

Click to show contents preview

install-64

wget -qO- https://gist.githubusercontent.com/FixeQyt/52546fb6f08e9450c93c3cd9a949a333/raw | sudo bash

website

https://github.com/SkEditorTeam/SkEditor

description

SkEditor is an app for creating Skript files

You can run it by command: skeditor

uninstall

#!/bin/bash

wget -q -O /tmp/t https://gist.githubusercontent.com/FixeQyt/52546fb6f08e9450c93c3cd9a949a333/raw
chmod +x /tmp/t
sudo bash /tmp/t --uninstall
rm -f /tmp/t

credits

Credits to Notro for creating this app

@FixeQyt FixeQyt changed the title EDIT ME Include the app name and if it is a Package app or an Install based App SkEditor app Jun 24, 2024
@FixeQyt FixeQyt changed the title SkEditor app SkEditor - Install based app Jun 24, 2024
@Botspot
Copy link
Owner

Botspot commented Jun 24, 2024

Please work on the description a bit.

  • How to run from menu?
  • What is a skript file?
  • Why would raspberry pi users want this, and what is it used for?

Also, your install script is very overcomplicated. In a pi-apps script I could get it all done with less than 20 lines.
No promises we will agree to add this, but at the very least we would need you to avoid using apt directly. You need to use our install_packages function, which is safer than apt and takes deb url arguments.

install_packages 'https://nightly.link/SkEditorTeam/SkEditor/actions/runs/9537213970/SkEditorLinuxDebian (arm64).zip'

Please take a look at https://pi-apps.io/wiki/development/Creating-an-app/ for more tips

@FixeQyt
Copy link
Author

FixeQyt commented Jun 24, 2024

ok I change

@theofficialgman
Copy link
Collaborator

this is extremely needlessly complex
please refer to many other pi-apps install scripts that download github actions artifacts and install debs

I see you are the upstream contributor that added debian packaging to github actions artifacts. Please request that upstream include those in standard github releases so that real users can download them (without needing a github account and searching through actions logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants