From 712ffcce1d66d1eabca6a2d047a7d1ef48b27b59 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 29 Aug 2024 10:04:08 +0200 Subject: [PATCH 1/4] Run GitHub Actions tests on macOS * #940 plus run the tests on macOS --- .github/workflows/nodejs.yml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 579d15d8..3c769382 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -13,21 +13,14 @@ jobs: fail-fast: false matrix: node: [18.x, 20.x, 22.x] - os: [ubuntu-latest, windows-latest, macOS-latest] - exclude: # TODO: Get macOS tests to pass by upgrading to https://github.com/nodejs/node-gyp/releases - - os: macos-latest - node: 18.x - - os: macos-latest - node: 20.x - - os: macos-latest - node: 22.x + os: [ubuntu-latest, windows-latest, macos-latest] steps: - name: Checkout repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Use Node ${{ matrix.node }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} cache: npm From 3e6f02987b60b3f90eec0581ec7f5824403d18b2 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 29 Aug 2024 10:25:48 +0200 Subject: [PATCH 2/4] package.json: Add node-gyp to dependencies --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 7d1e3b08..366e005f 100644 --- a/package.json +++ b/package.json @@ -6,6 +6,7 @@ }, "description": "Neural networks in JavaScript", "dependencies": { + "node-gyp": "^10.2.0", "thaw.js": "^2.1.4" }, "peerDependencies": { From be2918b2bc02e786d54c5711a475278aa6a256d3 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 29 Aug 2024 11:12:50 +0200 Subject: [PATCH 3/4] Revert changes to package.json --- package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package.json b/package.json index 366e005f..7d1e3b08 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,6 @@ }, "description": "Neural networks in JavaScript", "dependencies": { - "node-gyp": "^10.2.0", "thaw.js": "^2.1.4" }, "peerDependencies": { From e545d8dccf907a3176e34cd8f1061a3ce7795270 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Wed, 16 Oct 2024 16:33:39 +0200 Subject: [PATCH 4/4] Update nodejs.yml --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 3c769382..f49db918 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -12,7 +12,7 @@ jobs: strategy: fail-fast: false matrix: - node: [18.x, 20.x, 22.x] + node: [18.x, 20.x, 22.x] os: [ubuntu-latest, windows-latest, macos-latest] steps: