Skip to content

Commit

Permalink
src: add default initializer in tls_wrap
Browse files Browse the repository at this point in the history
PR-URL: nodejs#23567
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
richardhoehn authored and BridgeAR committed Oct 15, 2018
1 parent 093cf6f commit 45ef905
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
8 changes: 1 addition & 7 deletions src/tls_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,7 @@ TLSWrap::TLSWrap(Environment* env,
AsyncWrap::PROVIDER_TLSWRAP),
SSLWrap<TLSWrap>(env, sc, kind),
StreamBase(env),
sc_(sc),
write_size_(0),
started_(false),
established_(false),
shutdown_(false),
cycle_depth_(0),
eof_(false) {
sc_(sc) {
MakeWeak();

// sc comes from an Unwrap. Make sure it was assigned.
Expand Down
12 changes: 6 additions & 6 deletions src/tls_wrap.h
Original file line number Diff line number Diff line change
Expand Up @@ -149,19 +149,19 @@ class TLSWrap : public AsyncWrap,
BIO* enc_in_ = nullptr;
BIO* enc_out_ = nullptr;
std::vector<uv_buf_t> pending_cleartext_input_;
size_t write_size_;
size_t write_size_ = 0;
WriteWrap* current_write_ = nullptr;
WriteWrap* current_empty_write_ = nullptr;
bool write_callback_scheduled_ = false;
bool started_;
bool established_;
bool shutdown_;
bool started_ = false;
bool established_ = false;
bool shutdown_ = false;
std::string error_;
int cycle_depth_;
int cycle_depth_ = 0;

// If true - delivered EOF to the js-land, either after `close_notify`, or
// after the `UV_EOF` on socket.
bool eof_;
bool eof_ = false;

private:
static void GetWriteQueueSize(
Expand Down

0 comments on commit 45ef905

Please sign in to comment.