New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Mediator to Brighter #3370

Draft

iancooper wants to merge 45 commits into master from mediator

Member

iancooper commented Oct 30, 2024

The mediator is used to run a workflow across a number of Brighter handlers. It is influenced by AWS Step Functions. It provides orchestration instead of choreography when you have a flow of requests; as such it can make such workflows easier to manage.

(Other dotnet messaging frameworks call this is a saga; it is only really a saga in a distributed context, and we want to allow this to run both in and out of process).

iancooper added 2 commits

October 28, 2024 19:10


          chore: save work in progress

f52c18d


          feat: add ADR for a mediator and assembly

36890f5

iancooper added 2 - In Progress grabbed by assignee v10 .NET labels

iancooper self-assigned this

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene


          feat: required workflow classes to write setup of rist mediator test

d92cb84

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Code Health of new files: 10.00

View detailed results in CodeScene


          chore: safety check whilst releasing V9 and V10; does not build

556bb7a

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Code Health of new files: 10.00

View detailed results in CodeScene


          chore: safety checkin

3ed0e7e

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Code Health of new files: 10.00

View detailed results in CodeScene


          feat: add fire and forget action

e0c9c85

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Code Health of new files: 10.00

View detailed results in CodeScene


          feat: add requestreply outline

f8609b8

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Code Health of new files: 10.00

View detailed results in CodeScene


          fix: folder name causing issues on MacOS which believes it is an appl…

255d086

…ication

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Code Health of new files: 10.00

View detailed results in CodeScene


          feat: modifications to step and workflow responsibility

a321e30

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (10.00 -> 10.00)

View detailed results in CodeScene


          feat: add workflow data, over just using the bag

7a879e6

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (10.00 -> 10.00)

View detailed results in CodeScene


          feat: need correlation id on event and command to support workflow

b8eded1

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (10.00 -> 10.00)

View detailed results in CodeScene


          chore: check in to allow merging of master

5298d38

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.21 (8.87 -> 9.08)

View detailed results in CodeScene

iancooper added 2 commits

November 6, 2024 21:43


          chore: merge branch 'master' into mediator

ab16834


          feat: move completed workflows to the done state

92e344d


          fix: refactor relationship between job and step to be more explicit. …

6067bd4

…Make some fields private

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.44 (8.91 -> 9.36)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene


          fix: step advancement manages job state

8b4e5e4

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.44 (8.91 -> 9.36)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene


          fix: add cancellation token interrupt of runner to all tests

e5a6639

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.47 (8.91 -> 9.38)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene


          chore: safety check in; fixing failing tests

acef39d

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.47 (8.91 -> 9.38)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene


          fix: get the steps to save state, when they modify the job, not the r…

aa8ca95

…unner. Timing for in-process handlers requires this.

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.48 (8.91 -> 9.39)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene


          fix: add fault version of robust request-reply

1cea4ea

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.38 (9.19 -> 9.57)

View detailed results in CodeScene


          fix: add multi-threading support to Job

08b2e18

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.38 (9.19 -> 9.57)

View detailed results in CodeScene


          Update ASB Samples to use the Emulator (#3391)

67f3376

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.31 (9.30 -> 9.61)

View detailed results in CodeScene


          feat: adding a Wait step.

e118650

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.33 (9.30 -> 9.63)

View detailed results in CodeScene


          fix: don't try to await a thread; ensure we leave time for scheduler …

ca229f0

…to fire on a delay

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.33 (9.30 -> 9.63)

View detailed results in CodeScene


          chore: merge from master

059fff0

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.33 (9.30 -> 9.63)

View detailed results in CodeScene


          chore: merge with master

a7019a2

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.33 (9.30 -> 9.63)

View detailed results in CodeScene


          chore: safety check in; failing test on parallel split still

f35d999

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.33 (9.30 -> 9.63)

View detailed results in CodeScene


          fix: parallel split was not terminating

1ef0839

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.33 (9.30 -> 9.63)

View detailed results in CodeScene


          fix: we should pass data to the callbacks; was capturing variable in …

392dd4d

…enclosing scope in tests

codescene-delta-analysis bot approved these changes

View reviewed changes

codescene-delta-analysis bot left a comment

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.33 (9.30 -> 9.63)

View detailed results in CodeScene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

holytshirt Awaiting requested review from holytshirt holytshirt will be requested when the pull request is marked ready for review holytshirt is a code owner

DevJonny Awaiting requested review from DevJonny DevJonny will be requested when the pull request is marked ready for review DevJonny is a code owner

preardon Awaiting requested review from preardon preardon will be requested when the pull request is marked ready for review preardon is a code owner

At least 1 approving review is required to merge this pull request.

Labels

2 - In Progress grabbed by assignee .NET v10