Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bad import of d2l-navigation-shared-styles #179

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Remove bad import of d2l-navigation-shared-styles #179

merged 1 commit into from
Jul 27, 2022

Conversation

EvanLemieux
Copy link
Contributor

Removing import of d2l-navigation-shared-styles that was causing issues with webpack in folio.

@EvanLemieux EvanLemieux requested a review from a team as a code owner July 27, 2022 16:34
dlockhart
dlockhart approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will get converted to Lit shortly as well.

@EvanLemieux EvanLemieux merged commit 8f33915 into main Jul 27, 2022
@EvanLemieux EvanLemieux deleted the elemieux/fix-shared-styles branch July 27, 2022 16:49
@ghost
Copy link

ghost commented Jul 27, 2022

🎉 This PR is included in version 5.7.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlockhart dlockhart dlockhart approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanLemieux @dlockhart