Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused d2l-navigation-button-close #153

Merged
merged 4 commits into from
Jul 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ Please note that overridding the `left` slot will prevent the Back link from dis
</div>
<div slot="right">
<d2l-navigation-button text="A button">One Button</d2l-navigation-button>
<d2l-navigation-button-close></d2l-navigation-button-close>
<d2l-navigation-button text="Another button">Two Button</d2l-navigation-button>
</div>
</d2l-navigation-immersive>
Expand Down
75 changes: 0 additions & 75 deletions d2l-navigation-button-close.js

This file was deleted.

9 changes: 0 additions & 9 deletions demo/button-link.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import '@brightspace-ui/core/components/demo/demo-page.js';
import '@brightspace-ui/core/components/icons/icon.js';
import '../d2l-navigation-button.js';
import '../d2l-navigation-button-close.js';
import '../d2l-navigation-button-icon.js';
import '../d2l-navigation-button-notification-icon.js';
import '../d2l-navigation-link.js';
Expand Down Expand Up @@ -55,13 +54,6 @@ <h2>d2l-navigation-button-icon / d2l-navigation-link-icon</h2>
</div>
</d2l-demo-snippet>

<h2>d2l-navigation-button-close</h2>
<d2l-demo-snippet>
<div class="wrapper">
<d2l-navigation-button-close></d2l-navigation-button-close>
</div>
</d2l-demo-snippet>

<h2>d2l-navigation-button-notification-icon</h2>
<d2l-demo-snippet>
<div class="wrapper">
Expand Down Expand Up @@ -107,7 +99,6 @@ <h2>Combined</h2>
Settings
</d2l-navigation-button>
<d2l-navigation-button-notification-icon notification icon="tier3:notification-bell" text="Notification on" id="notified" notification-text="You have new notifications"></d2l-navigation-button-notification-icon>
<d2l-navigation-button-close></d2l-navigation-button-close>
</div>
</d2l-demo-snippet>

Expand Down
1 change: 0 additions & 1 deletion demo/immersive-fullscreen.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import '@brightspace-ui/core/components/demo/demo-page.js';
import '../components/d2l-navigation-iterator/d2l-navigation-iterator.js';
import '../d2l-navigation-button.js';
import '../d2l-navigation-button-close.js';
import '../d2l-navigation-immersive.js';
</script>
<title>d2l-navigation-immersive demo</title>
Expand Down
2 changes: 0 additions & 2 deletions demo/immersive-normal.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<script type="module">
import '@brightspace-ui/core/components/demo/demo-page.js';
import '../d2l-navigation-button.js';
import '../d2l-navigation-button-close.js';
import '../d2l-navigation-immersive.js';
</script>
<title>d2l-navigation-immersive demo</title>
Expand All @@ -30,7 +29,6 @@
</div>
<div slot="right">
<d2l-navigation-button text="A button">One Button</d2l-navigation-button>
<d2l-navigation-button-close></d2l-navigation-button-close>
<d2l-navigation-button text="Another button">Two Button</d2l-navigation-button>
</div>
</d2l-navigation-immersive>
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"/components",
"/lang",
"d2l-navigation-band.js",
"d2l-navigation-button-close.js",
"d2l-navigation-button-icon.js",
"d2l-navigation-button-notification-icon.js",
"d2l-navigation-button.js",
Expand Down
18 changes: 0 additions & 18 deletions test/button.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import '../d2l-navigation-button.js';
import '../d2l-navigation-button-close.js';
import '../d2l-navigation-button-icon.js';
import '../d2l-navigation-button-notification-icon.js';
import { expect, fixture, html, oneEvent } from '@open-wc/testing';
Expand Down Expand Up @@ -39,23 +38,6 @@ describe('Buttons', () => {

});

describe('d2l-navigation-button-close', () => {

describe('accessibility', () => {
it('should pass all aXe tests', async() => {
const el = await fixture(html`<d2l-navigation-button-close></d2l-navigation-button-close>`);
await expect(el).to.be.accessible();
});
});

describe('constructor', () => {
it('should construct', () => {
runConstructor('d2l-navigation-button-close');
});
});

});

describe('d2l-navigation-notification-icon', () => {

describe('accessibility', () => {
Expand Down
4 changes: 0 additions & 4 deletions test/button.visual-diff.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import '@brightspace-ui/core/components/icons/icon.js';
import '@brightspace-ui/core/components/typography/typography.js';
import '../../d2l-navigation-button.js';
import '../../d2l-navigation-button-close.js';
import '../../d2l-navigation-button-icon.js';
import '../../d2l-navigation-button-notification-icon.js';
import { forceFocusVisible } from '@brightspace-ui/core/helpers/focus.js';
Expand All @@ -23,9 +22,6 @@
<div class="visual-diff">
<d2l-navigation-button id="disabled" text="Classes" disabled><d2l-icon icon="tier3:classes"></d2l-icon></d2l-navigation-button>
</div>
<div class="visual-diff">
<d2l-navigation-button-close id="close"></d2l-navigation-button-close>
</div>
<div class="visual-diff">
<d2l-navigation-button-icon id="icon-text" icon="tier3:classes" text="Classes"></d2l-navigation-button-icon>
</div>
Expand Down
1 change: 0 additions & 1 deletion test/button.visual-diff.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ describe('d2l-navigation-button', () => {
[
{ category: 'default', tests: ['normal', 'hover', 'focus'] },
{ category: 'disabled', tests: ['normal', 'hover', 'focus'] },
{ category: 'close', tests: ['normal', 'hover', 'focus'] },
{ category: 'icon-text', tests: ['normal', 'hover', 'focus'] },
{ category: 'icon-text-disabled', tests: ['normal', 'hover', 'focus'] },
{ category: 'icon-text-hidden', rectSelector: 'icon-text-hidden-container', tests: ['normal', 'hover', 'focus'] },
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.