fix: switch back link to use link icon #156
Conversation
|
Visual diff tests failed - pull request #157 has been opened with the updated goldens. |
| @@ -133,10 +133,6 @@ class D2LNavigationImmsersive extends DirMixin(PolymerElement) { | |||
| visibility: hidden; | |||
| } | |||
|
|
|||
| d2l-navigation-link-back { | |||
| --d2l-navigation-link-back-left-padding: 12px; | |||
There was a problem hiding this comment.
This was the only place overriding this padding value -- I checked with Jeff and he saw no need to do this.
| @@ -179,10 +175,6 @@ class D2LNavigationImmsersive extends DirMixin(PolymerElement) { | |||
| margin: 0 18px; | |||
| padding: 0 18px; | |||
| } | |||
| d2l-navigation-link-back { | |||
| --d2l-navigation-link-back-left-padding: 6px; | |||
| margin: 0 | |||
There was a problem hiding this comment.
No margin was set, so this was doing nothing.
| :host { | ||
| display: inline-block; | ||
| height: 100%; | ||
| white-space: nowrap; |
There was a problem hiding this comment.
The nowrap is set in d2l-navigation-link-icon, so not needed.
| } | ||
|
|
||
| render() { | ||
| const href = this.href ? this.href : 'javascript:void(0);'; // backwards-compatible for uses before missing "href" threw exception |
There was a problem hiding this comment.
I was hoping to avoid this, but there are quite a few places (including the LMS) that are abusing it.
| @@ -30,6 +30,7 @@ export const highlightLinkStyles = css` | |||
| position: relative; | |||
| text-decoration: none; | |||
| vertical-align: middle; | |||
| white-space: nowrap; | |||
There was a problem hiding this comment.
This should have always been here, to avoid text/icon wrapping onto separate lines.
Co-authored-by: github-actions <github-actions@github.com>
|
🎉 This PR is included in version 5.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
A pretty simple swap here -- now that
<d2l-navigation-link-icon>exists,<d2l-navigation-link-back>can just use it directly.Had to fix this sequences usage, which was reaching into the shadow DOM:
https://github.com/BrightspaceHypermediaComponents/sequences/pull/442
I'm expecting a
1pxwidth increase as the spacing between the icon and text will go from5pxto6px.