Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix d2l-navigation-iterator import #188

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fix d2l-navigation-iterator import #188

merged 1 commit into from
Aug 19, 2022

Conversation

ChrisLabattD2L
Copy link
Contributor

I've added how to npm install this repo since it was missing and also corrected the import for the d2l-navigation-iterator component.

@ChrisLabattD2L ChrisLabattD2L requested a review from a team as a code owner August 19, 2022 14:41
dlockhart
dlockhart approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm 90% through converting this to Lit and was going to do a full README audit at that point, but this is still great.

@dlockhart dlockhart merged commit dc6ffc9 into main Aug 19, 2022
@dlockhart dlockhart deleted the ChrisLabattD2L-patch-1 branch August 19, 2022 14:50
@ghost
Copy link

ghost commented Aug 19, 2022

🎉 This PR is included in version 5.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ChrisLabattD2L
Copy link
Contributor Author

Thanks! I'm 90% through converting this to Lit and was going to do a full README audit at that point, but this is still great.

Didn't realize that conversion was underway! I was just trying to get it set up and figured I'd just add it since it was missing 😄

@ghost ghost added the released label Aug 19, 2022
@svanherk svanherk mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlockhart dlockhart dlockhart approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisLabattD2L @dlockhart